Coder Social home page Coder Social logo

Comments (4)

eytan-avisror avatar eytan-avisror commented on July 23, 2024

minion-manager should support providing recommendation so that it is compatible with eks-cf provisioner - the work has already been done on the recommendation reconciler here #36 .

You are talking about making changes to a reconciling object from other components - this will always be a problem if you go around the controller.

Even when using SDK to create resources, if a different component changes something under the controller then the next reconcile will try to take it back to whatever the CR is declaring as the desired state.

Regardless of that, we should have an eks-sdk provisioner - this however would require significant amount of work and is a matter of prioritizing.

from instance-manager.

shrinandj avatar shrinandj commented on July 23, 2024

Agreed that minion-manager could implement the events based approach and get the desired result. But what about cases where tags on the ASGs need to be updated at run time (new tags added, old tags removed, etc.). One use-case for that is to enable/disable cluster-autoscaler.

from instance-manager.

eytan-avisror avatar eytan-avisror commented on July 23, 2024

Tags are not overwritten by reconcile, only Cloudformation objects (tags are part of the API call, not the template)

Outside of that - cloudformation will not strip manually added tags according to what we tested

from instance-manager.

eytan-avisror avatar eytan-avisror commented on July 23, 2024

fixed by #83

from instance-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.