Comments (4)
minion-manager
should support providing recommendation so that it is compatible with eks-cf
provisioner - the work has already been done on the recommendation reconciler here #36 .
You are talking about making changes to a reconciling object from other components - this will always be a problem if you go around the controller.
Even when using SDK to create resources, if a different component changes something under the controller then the next reconcile will try to take it back to whatever the CR is declaring as the desired state.
Regardless of that, we should have an eks-sdk
provisioner - this however would require significant amount of work and is a matter of prioritizing.
from instance-manager.
Agreed that minion-manager
could implement the events based approach and get the desired result. But what about cases where tags on the ASGs need to be updated at run time (new tags added, old tags removed, etc.). One use-case for that is to enable/disable cluster-autoscaler.
from instance-manager.
Tags are not overwritten by reconcile, only Cloudformation objects (tags are part of the API call, not the template)
Outside of that - cloudformation will not strip manually added tags according to what we tested
from instance-manager.
fixed by #83
from instance-manager.
Related Issues (20)
- Upgrade approval for changes to Instance Groups HOT 1
- Support container-runtime bootstrap argument
- Delay/Schedule automated AMI updates HOT 1
- Required selectors in configs HOT 4
- Label nodes in a single zone IG with AZ ID HOT 2
- SubFamilyFlexible calculations should ensure that instance types have the same supported architectures.
- Use kubernetes labels to exclude instances from the upgrade() cycle HOT 6
- instance-manager always creates normal EC2 instances regardless of the spotPrice value HOT 3
- Support for K8s 1.22 HOT 1
- Subnets field should deduplicate if duplicate values are provided
- Endless LaunchTemplate creation loop when reconcile errors occur
- Changing a boundary does not roll back changes on CRs
- Cluster Autoscaler unable to scale up nodes from EKS autoscaling group warm pool when pods request ephemeral storage HOT 26
- When switching primaryType with MixedInstances, type is not added to overrides
- Use IMDS for Warm Pools & ASG state
- Explore concept of VNA - Vertical Node Autoscaler HOT 3
- Add a Capacity Rebalance Flag for Spot Node Allocation Strategy
- Instance profile is stuck in bad state if error occurs when initial role is attached
- IGs in special AWS partitions always fails ARN format validation in instance_types.go
- not honoring gp3 volume iops and throughput values
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from instance-manager.