App Crashes when blockchain download is (nearly) done about bitcoinspv

[turcane]

Tested also with a seed with just 1 transaction and 1 account.
Same result -> Crash

[keeshux]

At least it's a "controlled crash", i.e. the library itself is raising an exception, because the path for the WSHDWallet object was not set. As suggested, you must invoke saveToPath: at least once when autosave is enabled, otherwise the wallet wouldn't know where to save. I understand it's not so obvious and can be improved, but it's how it is now.

Can you please post the code you described in the above steps instead?

[turcane]

I've created bridging header, this is my code:

    let parameters = WSParametersForNetworkType(WSNetworkTypeMain)
    let seed = WSSeedMakeFromISODate("...some mnemonic...", "2016-09-29")
    let store = WSMemoryBlockStore.init(parameters: parameters)
    let wallet = WSHDWallet.init(parameters: parameters, seed: seed)
    wallet?.save(toPath: "/")
    let downloader = WSBlockChainDownloader.init(store: store, wallet: wallet)
    let peerGroup = WSPeerGroup.init(parameters: parameters)
    peerGroup?.startConnections()
    peerGroup?.startDownload(with: downloader)

Also crashing if "shouldAutoSave" is set to false.
I can provide you whole project, if this helps

[keeshux]

I think it's the quickest option, send it over to me via email.

[turcane]

I will invite you to the private project. Please don't spend coin, which are on the seed. But you can use them for testing purposes :)

/edit
Invited. I tried it with a real device (iPhone 7) and iPhone 5 Simulator. Same result. On iOS10 of course.

[keeshux]

@JediWed

- (BOOL)saveToPath:(NSString *)path
{
    WSExceptionCheckIllegal(path);

    @synchronized (self) {
        if (![NSKeyedArchiver archiveRootObject:self toFile:path]) {
            return NO;
        }
        DDLogInfo(@"Saved wallet to %@", path);
        _path = path;
        return YES;
    }
}

I hadn't noticed that you're trying to save to /, the result is that archiveRootObject obviously fails. You should save files to app's sandbox directories instead. Generally speaking, you must ensure that saveToPath: succeeds before serializing the wallet.

I'm adding a warning just in case, but this is a non-issue. Closing.

[turcane]

Great, thank you very much!