Comments (8)
Well this is a tricky one.. the situation I saw with Windows (only with Windows) is that if the delay from the dialog response is too long the length variable from STDIN is zero, and after that keepassxc-proxy.exe just quits (no crash, it quits). I tried to put some breakpoints here and there but couldn't catch the exact point where it quits.
Can you confirm the keepassxc-proxy.exe quits in your situation too?
from keepassxc-browser.
There should be some form of a continuous heartbeat if you break the connection due to lack of input.
from keepassxc-browser.
There's already a while loop that doesn't break until EOF is met (or running has stopped but that's not the case). I'll take a look at this later and try to figure out what exactly happens here.
EDIT: It indeed gets an EOF. When debugging KeePassXC I didn't see it at all, but I can see "No logins found" error in the browser extension logs before responding the dialog. There's not even timeout for credential receiving. So this is a really tricky one..
from keepassxc-browser.
Yah, try not to put in magic delays and such to fix this... We control the protocol so let's make it robust.
from keepassxc-browser.
I won't. This is an asynchronous method so STDIN shouldn't get EOF in any situation because this means the browser shuts the connection down. I confirmed that onDisconnect()
hits with an unknown error. And this only happens with Windows.
from keepassxc-browser.
Has this been fixed?
from keepassxc-browser.
Probably needs some more testing so let's reopen this.
from keepassxc-browser.
Re-tested this. Everything works fine.
from keepassxc-browser.
Related Issues (20)
- Confuses various input fields with OTP fields HOT 4
- ITS: Basic ticket searches not user-friendly HOT 1
- Update accessed date when entry is used to populate login fields HOT 2
- [Serious] Breaks browser styleseets for XML documents HOT 5
- extension does not work on Linux selenium 6.8.0-38-generic with chromium HOT 1
- UI Change - Extension now barely usable HOT 10
- Entry selection drop-down scrollbar doesn't respect theme HOT 3
- Browser extension unable to connect HOT 2
- Please have some way of dismissing the popup HOT 5
- KeePass XC's Tor integration breaks torbrowser-launcher HOT 7
- Username updating adds the category onto the username when updating the password HOT 3
- Floating Icon after login HOT 1
- TypeError: 'toJSON' called on an object that does not implement interface PublicKeyCredential. HOT 1
- Advanced string fields should be disambiguated when there are multiple entries for the same URL HOT 4
- KeePassXC-Browser addon not working with firejailed Firefox HOT 6
- "Save Credentials" does not save the credentials HOT 5
- Non-text inputs falsely get detected as segmented TOTP
- Cannot connect Firefox (Mozilla PPA) on (K)ubuntu 24.04 HOT 4
- regression from PR #1841 #1857 HOT 6
- Firefox Extension Seemingly Broken When Trying to Autofill the "accounts.firefox.com" URL HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from keepassxc-browser.