Coder Social home page Coder Social logo

Comments (8)

varjolintu avatar varjolintu commented on August 24, 2024

Well this is a tricky one.. the situation I saw with Windows (only with Windows) is that if the delay from the dialog response is too long the length variable from STDIN is zero, and after that keepassxc-proxy.exe just quits (no crash, it quits). I tried to put some breakpoints here and there but couldn't catch the exact point where it quits.

Can you confirm the keepassxc-proxy.exe quits in your situation too?

from keepassxc-browser.

droidmonkey avatar droidmonkey commented on August 24, 2024

There should be some form of a continuous heartbeat if you break the connection due to lack of input.

from keepassxc-browser.

varjolintu avatar varjolintu commented on August 24, 2024

There's already a while loop that doesn't break until EOF is met (or running has stopped but that's not the case). I'll take a look at this later and try to figure out what exactly happens here.

EDIT: It indeed gets an EOF. When debugging KeePassXC I didn't see it at all, but I can see "No logins found" error in the browser extension logs before responding the dialog. There's not even timeout for credential receiving. So this is a really tricky one..

from keepassxc-browser.

droidmonkey avatar droidmonkey commented on August 24, 2024

Yah, try not to put in magic delays and such to fix this... We control the protocol so let's make it robust.

from keepassxc-browser.

varjolintu avatar varjolintu commented on August 24, 2024

I won't. This is an asynchronous method so STDIN shouldn't get EOF in any situation because this means the browser shuts the connection down. I confirmed that onDisconnect() hits with an unknown error. And this only happens with Windows.

from keepassxc-browser.

phoerious avatar phoerious commented on August 24, 2024

Has this been fixed?

from keepassxc-browser.

varjolintu avatar varjolintu commented on August 24, 2024

Probably needs some more testing so let's reopen this.

from keepassxc-browser.

varjolintu avatar varjolintu commented on August 24, 2024

Re-tested this. Everything works fine.

from keepassxc-browser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.