Comments (2)
To supplement this. it's fair to say that it's the user's responsibility to make sure they use a trusted file for the logging. If the Kedro pipeline is exposed via API or embedded in application. We recommend not to expose KEDRO_LOGGING_CONFIG
to any external input to avoid this potential vulnerability.
from kedro.
Summary
In discussion with @noklam and @merelcht -
The only way to silence the Snyk warning is to check the path provided by the env variable KEDRO_LOGGING_CONFIG
is inside a "safe directory". This isn't very easy to solve since we don't know in advance where the user's logging.yml
will be.
Even if we could assume that the logging config file is within the project(project_path
) or in the conf_source
but those values are accessible when a session is created which happens much later after the logging has been set up. Also, with the addition of the ability of specifying conf-source
, the conf
is not necessarily located in the project and/or could be a zip/tar file.
The decision then is to make no changes to address this but rely on the user to make sure that the path to the logging file is not arbitrary.
from kedro.
Related Issues (20)
- ci: Nightly build failure on `develop` HOT 3
- ci: Nightly build failure on `main` HOT 1
- Update `kedro new` hint and docs to clarify how to provide a project tools selection to `--tools`
- ci: Nightly build failure on `develop` HOT 2
- DatasetAlreadyExistsError thrown when using ThreadRunner, dataset factories HOT 4
- Maintenance of documentation versions is complex HOT 5
- Consider removing micropackaging HOT 2
- Improve Developer Experience
- Improve logging experience
- %load_node truncates import statements HOT 2
- ci: Nightly build failure on `main` HOT 1
- Upgrade Pluggy depdendency version (<1.4) - Preventing upgrade of Pytest 8.1 that requires pluggy >=1.4 HOT 6
- Monthly issue metrics report
- Update CONTRIBUTING.md and other instructions with new usage of Discussions vs Issues
- Release `kedro` 0.19.4 HOT 3
- Can't build docs in starter - need to update sphinx version HOT 2
- Improve `kedro jupyter setup` with options from `ipykernel install` HOT 1
- Kedro new starter CLI : user_input.lower() HOT 5
- Deprecate (mark for future removal) `get_pkg_version` from the public API HOT 5
- Decouple starters from framework in tool selection flow
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kedro.