Coder Social home page Coder Social logo

Comments (5)

pst avatar pst commented on July 17, 2024 1

Happy to review your contribution whenever you get around to it.

If you add the variable to the .tf files in src/_terraform_module the changes will automatically be included in all future module versions built. That includes both the ones that bundle upstream like nginx or cert-manager, but also the custom-manifests module.

from terraform-kubestack.

pst avatar pst commented on July 17, 2024

Thanks for the suggestion. Here's big picture what needs to be done for anyone interested to pick this up:

First needs support in the provider here: https://github.com/kbst/terraform-provider-kustomization
Then the variable can be exposed in the module here: https://github.com/kbst/catalog/tree/master/src/_terraform_module

from terraform-kubestack.

mathe-matician avatar mathe-matician commented on July 17, 2024

@pst

First needs support in the provider here

To clarify, isn't it already supported in the repo here? https://github.com/kbst/terraform-provider-kustomization/blob/c75a675049a3c88b285dc53600ac7d5b380d5f72/kustomize/data_source_kustomization_overlay.go#L338

So it would just need to be exposed in the custom-manifest module?

Edit:

I would love to pick this issue up too regardless. Let me know if that is possible.

from terraform-kubestack.

pst avatar pst commented on July 17, 2024

You are right, replacements seem to already be supported in the provider. I guess I lost track myself.

from terraform-kubestack.

mathe-matician avatar mathe-matician commented on July 17, 2024

@pst no worries - I'm still willing to contribute to the second part you mentioned above:

Then the variable can be exposed in the module here: https://github.com/kbst/catalog/tree/master/src/_terraform_module

from terraform-kubestack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.