Comments (3)
Peter and I were also interested in a DiracDelta prior, to fix e.g. the sky localisation to simplify the PE which might be useful to look into the sampling process itself and debug it. I haven't started on that, but that would also require a composite prior with some parameters having a uniform, and some having a DiracDelta prior. I'll ping u in case I start working on this at some point.
from jim.
Hi @kazewong , I was doing some PE runs on GW170817 and the luminosty distances are a bit off, because we are using the Uniform prior instead of a cosmological prior on the distance, as done in the TurboPE repo here. We were wondering, since you seemed to be working on prior classes, if it would be easy for you to add such a prior class to Jim? I am more than happy to help by implementing it myself in case you don't have time for it right now, but just wanted to check in case you are already working on something like this. Thanks a lot in advance!
from jim.
I think this can be handled. A slightly tricky bit is where do we want the dependency of cosmological parameters to live. I am fine with having astropy
as a dependency to create the data for redshift/distance interpolation when initializing the class, but that would mean we cannot differentiate against the cosmological parameters. There exist some packages in jax that offers cosmology related calculation that can be diff/jit, but I am not comfortable integrating those into our dependency.
On the Dirac delta prior, I think in general we don't want that since that unnecessarily inflates the dimensionality of the problem. Further more, gradient-based samplers like HMC and MALA will probably encounter troubles with these types of prior. On top of this, I think this can be handled much more elegantly on the likelihood/model level. We can have some example for that later
from jim.
Related Issues (20)
- Allow freedom in choosing different parametrization HOT 1
- Adam optimizer doesn't work for some cases HOT 2
- SingleEventRun requires path for injection HOT 3
- 3G detectors in Jim
- Periodic Boundary Condition in Prior
- Write Tuning Guide for Jim
- Add Post-processing Pipeline HOT 1
- Moving naming tracking into Jim class from Prior class HOT 1
- Add Population Interface HOT 1
- Test All Reparametrization
- Use autotune for MALA in RunManager Default HOT 1
- Set default bounds to be the prior bounds in run manager HOT 1
- Update the run manager HOT 3
- The Jacobian determinant for transformation should take absolute value HOT 2
- Write a guide for the new prior and naming system HOT 1
- Redundant transform in prior class HOT 1
- Outputting dict instead of array for jim.get_samples
- Output numpy array instead of jax.numpy array
- Add cosmological model for the conversation from red-shifted mass to source-frame mass
- Slow initialize point generation HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jim.