invalid markup inside <noscript>-Tag about typo3.piwik

[kaystrobach]

@tomtom-berlin could you please use urlencode and do a Merge Request, IMHO you should be able to do the pull request via the webUI as well. Thx

[tomtom-berlin]

Hey,

urlencode at that place will not work because it masks all characters, including slashes and question marks a.s.o. of url scheme and hostname.
%2F%2Fmyhost.tld%sFpiwik.php%3F... doesn’t look so well :) To get that I have to dive deeper into the project, but I’m just out of time to do more than my workaround.

I’m not so familiar with git, but i will do my very best tonight. I did not check out the extension yet but load it via TYPO3 extension manager. While I am testing my new web project the w3 validator throws a few errors inside the tag of the piwik extension, though I fumbled around for a solution…
But yes, I will check it out this evening and merge it back, if you didn’t mind.

Greetings, Thomas.

Am 14.04.2015 um 06:42 schrieb Kay Strobach [e-mail]:

@tomtom-berlin could you please use urlencode and do a Merge Request, IMHO you should be able to do the pull request via the webUI as well. Thx

—
Reply to this email directly or view it on GitHub.

[kaystrobach]

yeah, sry i meant htmlspecialchars that's what can happen if you type on mobile ... sry

[tomtom-berlin]

could not merge or sync it because of insufficient permissions.
Greetings, Thomas.

Am 14.04.2015 um 06:42 schrieb Kay Strobach [e-mail]:

@tomtom-berlin could you please use urlencode and do a Merge Request, IMHO you should be able to do the pull request via the webUI as well. Thx

—
Reply to this email directly or view it on GitHub.

[kaystrobach]

see here for more information, normally all repos are write protected ... it's about security.

Please create a pull request

https://help.github.com/articles/using-pull-requests/

[tomtom-berlin]

Hello,

I hope to get it right now, made a pull request 5 minutes ago... As said, I'm not very familiar with git/github.

Another question: does your extension respect the DNT-header? I tried with both settings, on and off, and in both cases the tracking code is inserted into the site markup before the closing -Tag. Shouldn't there be a notice like 'Not tracked because of active DNT-header' or similar, as it is when I'm logged in as a backend-user?

Greetings, Thomas.

Am 15.04.2015 um 05:51 schrieb Borrmann Thomas [e-mail]:

could not merge or sync it because of insufficient permissions.
Greetings, Thomas.

Am 14.04.2015 um 06:42 schrieb Kay Strobach [e-mail]:

@tomtom-berlin could you please use urlencode and do a Merge Request, IMHO you should be able to do the pull request via the webUI as well. Thx

—
Reply to this email directly or view it on GitHub.

[kaystrobach]

thank you pull request is merged now!

The DNT header is not respected by the extension itself, but should be by your piwik integration.

Reason is easy, adding another TYPO3Script condition will pollute you caching tables even more so i tried to avoid that and prefer to use the stuff shipped with piwik.