Ionic 3 Time Bug (minute == 0) about ion-datetime-picker

[olga2323]

Any progress on this? I would volunteer to help, should I generate a pull request?

[katemihalikova]

I'm not actively maintaining the ionic3 version as it's just a draft demo using ionic internal stuff, but you can surely fork it :) I might also accept a PR if it's a simple change.

[olga2323]

can you grant me access, would like to push changes to issue branch

[olga2323]

[issue/113/minute-second-can-be-zero] acv-mac:~/development/ion-datetime-picker $ git push -u origin issue/113/minute-second-can-be-zero
ERROR: Permission to katemihalikova/ion-datetime-picker.git denied to olga2323.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

[olga2323]

Hi Kate,

b.t.w. this is the diff if you want to do that by yourself...

diff --git a/src/picker.directive.ts b/src/picker.directive.ts
index a1b78e9..a90fba3 100644
--- a/src/picker.directive.ts
+++ b/src/picker.directive.ts
@@ -56,8 +56,8 @@ export class DatetimePickerDirective {
val.month ? val.month - 1 : (pickerOptions.dateEnabled ? now.getMonth() : 0),
val.day || (pickerOptions.dateEnabled ? now.getDate() : 1),
val.hour || (pickerOptions.timeEnabled ? now.getHours() : 0),

•  val.minute || (pickerOptions.timeEnabled ? now.getMinutes() : 0),
  

•  val.second || (pickerOptions.timeEnabled && pickerOptions.secondsEnabled ? now.getSeconds() : 0),
  

•  (val.minute==undefined?(pickerOptions.timeEnabled ? now.getMinutes() : 0):val.minute),
  

•  (val.second==undefined?(pickerOptions.timeEnabled && pickerOptions.secondsEnabled ? now.getSeconds() : 0):val.second),
  

  );

[olga2323]

issue113.patch.gz

[katemihalikova]

Fixed in d7947f5 and released as [email protected], thanks! Let me know whether it's fixed or if there is any problem with this version.

You need to go a little different way when you want tocontribute to a repo that is not yours, see Forking Projects by GitHub Guides.