Coder Social home page Coder Social logo

Comments (11)

vbmade2000 avatar vbmade2000 commented on June 11, 2024 2

Can I work on this simple issue ?

from agent.

sameo avatar sameo commented on June 11, 2024

@vbmade2000 Yes, please do.

from agent.

vbmade2000 avatar vbmade2000 commented on June 11, 2024

@sboeuf There does not exist github.com/opencontainers/runc/libcontainer/nsenter path. in vendors It exists in runc repo in release v1.0.0-rc4.

from agent.

jodh-intel avatar jodh-intel commented on June 11, 2024

@sboeuf - when you are back tomorrow, could you also add a bit more detail to this issue explaining why the container spawn will fail?

from agent.

sboeuf avatar sboeuf commented on June 11, 2024

@jodh-intel I have updated the issue description.

from agent.

jodh-intel avatar jodh-intel commented on June 11, 2024

Thanks @sboeuf.

from agent.

sboeuf avatar sboeuf commented on June 11, 2024

@vbmade2000 I don't get what is the problem here ? The vendoring of github.com/opencontainers/runc refers to the version 1.0.0-rc4 as you mentioned. And the nsenter package does exist for this version.
Now if what you mean is that nsenter is not into the /vendor/... directory, this will be solved by first modifying the code so that you actually import _ "github.com/opencontainers/runc/libcontainer/nsenter", and then by running the following command:

dep ensure && dep ensure -update github.com/opencontainers/runc && dep prune

from agent.

sameo avatar sameo commented on June 11, 2024

@vbmade2000 You need to add the import into the code and then dep will detect this new dependency and add nsenter to the vendoring path.

As @sboeuf said, you need to run:

dep ensure -v && dep ensure -update -v github.com/opencontainers/runc && dep prune -v

from agent.

sboeuf avatar sboeuf commented on June 11, 2024

@vbmade2000 are you still planning on implementing this ?
I am sorry to rush you here but we're trying to enable our runtime with the Kata agent, and we would need this to be merged asap.

from agent.

vbmade2000 avatar vbmade2000 commented on June 11, 2024

@sboeuf I am done with it. Raising PR now.

from agent.

sboeuf avatar sboeuf commented on June 11, 2024

Cool thank you 😄

from agent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.