Comments (11)
Can I work on this simple issue ?
from agent.
@vbmade2000 Yes, please do.
from agent.
@sboeuf There does not exist github.com/opencontainers/runc/libcontainer/nsenter path. in vendors It exists in runc repo in release v1.0.0-rc4.
from agent.
@sboeuf - when you are back tomorrow, could you also add a bit more detail to this issue explaining why the container spawn will fail?
from agent.
@jodh-intel I have updated the issue description.
from agent.
Thanks @sboeuf.
from agent.
@vbmade2000 I don't get what is the problem here ? The vendoring of github.com/opencontainers/runc
refers to the version 1.0.0-rc4 as you mentioned. And the nsenter
package does exist for this version.
Now if what you mean is that nsenter is not into the /vendor/...
directory, this will be solved by first modifying the code so that you actually import _ "github.com/opencontainers/runc/libcontainer/nsenter"
, and then by running the following command:
dep ensure && dep ensure -update github.com/opencontainers/runc && dep prune
from agent.
@vbmade2000 You need to add the import into the code and then dep
will detect this new dependency and add nsenter
to the vendoring path.
As @sboeuf said, you need to run:
dep ensure -v && dep ensure -update -v github.com/opencontainers/runc && dep prune -v
from agent.
@vbmade2000 are you still planning on implementing this ?
I am sorry to rush you here but we're trying to enable our runtime with the Kata agent, and we would need this to be merged asap.
from agent.
@sboeuf I am done with it. Raising PR now.
from agent.
Cool thank you 😄
from agent.
Related Issues (20)
- action: Improve porting checks
- action: Improve porting checks
- action: Improve porting checks
- github: Remove issue template and use central one
- Race between getDeviceName() and uevent arrival
- Passing PCI device information from host to VM is limited and messy HOT 5
- fail to hotplug device if host memory size large enough HOT 7
- make proto fail using docker 18.06 on arm64
- Kata 2.0.0 doesn't play well with Docker HOT 1
- Mount failed with "rw,stripe=1024" HOT 2
- may be a fd leak? HOT 1
- enable github actions
- hugepage support in Kata
- guest OCI hooks failed to find config.json HOT 1
- backport github actions for stable-1.12
- /dev/pts/N leak HOT 1
- pci bus path changes in qemu/arm64 vm when using acpi
- mount: don't error of virtiofs share is already mounted HOT 1
- running oci hook fail with "wait: no child processes" error sometimes when stop container HOT 1
- Revert 1.13.0-alpha1 version bump, as the release was never tagged.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from agent.