PolicyMarkedLabels and policyMarkedAnnotations of rb/crb may be lost when deleting the old pp/cpp and binding a new one about karmada

[whitewindmills]

great analysis, do you have any idea to fix this?

[zhzhuang-zju]

great analysis, do you have any idea to fix this?

When performing a clean up of marks on rb/crb, we can compare the value of the label policyv1alpha1.ClusterPropagationPolicyPermanentIDLabel on the cb/crb with the policyId value of the deleted CPP/PP. If they are not the same, it indicates that the rb/crb has already claimed to a new CPP/PP, and there is no need to clean up the label/annotation.

just like:

func (d *ResourceDetector) HandleClusterPropagationPolicyDeletion(policyID string) error {
	var errs []error
	labelSet := labels.Set{
		policyv1alpha1.ClusterPropagationPolicyPermanentIDLabel: policyID,
	}

	cleanupMarksFun := func(obj metav1.Object) bool {
		if obj.GetLabels()[policyv1alpha1.ClusterPropagationPolicyPermanentIDLabel] != policyId {
			return false
		}
		util.RemoveLabels(obj, clusterPropagationPolicyMarkedLabels...)
		util.RemoveAnnotations(obj, clusterPropagationPolicyMarkedAnnotations...)
		return true
	}
        ... ...
}

func (d *ResourceDetector) CleanupResourceBindingMarks(rb *workv1alpha2.ResourceBinding, cleanupFunc func(obj metav1.Object) bool) error {
	return retry.RetryOnConflict(retry.DefaultRetry, func() (err error) {
		if !cleanupFunc(rb) {
			klog.Infof("xxxx no need to clean up xxx")
			return nil
		}
		updateErr := d.Client.Update(context.TODO(), rb)
		if updateErr == nil {
			return nil
		}

		updated := &workv1alpha2.ResourceBinding{}
		if err = d.Client.Get(context.TODO(), client.ObjectKey{Namespace: rb.GetNamespace(), Name: rb.GetName()}, updated); err == nil {
			rb = updated.DeepCopy()
		} else {
			klog.Errorf("Failed to get updated resource binding %s/%s: %v", rb.GetNamespace(), rb.GetName(), err)
		}
		return updateErr
	})
}

[whitewindmills]

it's a good answer.

[XiShanYongYe-Chang]

In favor of #5319
/assign

[XiShanYongYe-Chang]

I'm sorry, I made the wrong assign.
/assign @zhzhuang-zju
/unassign