Coder Social home page Coder Social logo

CMake Setup Suggestions about mailio HOT 8 CLOSED

karastojko avatar karastojko commented on May 14, 2024
CMake Setup Suggestions

from mailio.

Comments (8)

karastojko avatar karastojko commented on May 14, 2024 1

Hi Paul,
Thank you for the feedback. I agree with you. One of the contributors was so kind to create the initial version of the CMake script. I have planned to add building examples, and definitely there are more space for improvements. If you don't mind, make a PR and then I will test it and merge it.

from mailio.

karastojko avatar karastojko commented on May 14, 2024 1

@DeveloperPaul123 @EarthlingKira
I am fine with CMake 3.10, I've been using versions 3.10, 3.11 i 3.12 for a while. From the moment when Boost 1.66 became the minimal required version (starting at July), I have also upgraded CMake requirements. Anyway, the version 2.8 in CMakeLists.txt is put by the original contributor @TrevorMellon , so perhaps he could advice on this topic too.

from mailio.

DeveloperPaul123 avatar DeveloperPaul123 commented on May 14, 2024

Sounds good!

from mailio.

DeveloperPaul123 avatar DeveloperPaul123 commented on May 14, 2024

@karastojko How do you feel about upgrading the minimum required version of CMake needed? I can really clean up and improve the setup greatly, but it will require some of the newer features available in the latest versions of CMake (probably somewhere between 3.8 and 3.10).

from mailio.

audaki avatar audaki commented on May 14, 2024

@DeveloperPaul123 @karastojko

I'm personally a "bleeding-edge" kind of dev, and since I'm one of the people who are using this library in a commercial production setting (shameless self-plug: https://firstbill.de , a German invoicing web-app in C++) I would like to give my opinion: Our production servers are already running cmake 3.10.2 (openSUSE Leap 15), so this would be okay for us.

But it might be a problem for others, see:

https://gitlab.kitware.com/cmake/community/wikis/doc/cmake/Life-Cycle-Considerations

from mailio.

DeveloperPaul123 avatar DeveloperPaul123 commented on May 14, 2024

@karastojko I see that you have made some changes to the cmake setup. Do you prefer to keep everything in a single file?

from mailio.

karastojko avatar karastojko commented on May 14, 2024

One file for the library and one for the examples is just fine. I am merging the PR to master.

from mailio.

DeveloperPaul123 avatar DeveloperPaul123 commented on May 14, 2024

Awesome thanks!

from mailio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.