Wrong ChainfOfResponsility pattern about design-patterns-for-humans

[weburnit]

My propose

interface PackageBuilderInterface
{
    /**
     * Package
     *
     * @param PackageItemInterface $item
     *
     * @return bool
     */
    public function pack(PackageItemInterface $item);

    /**
     * @return array
     */
    public function getPackages():array;
}

interface PackageItemInterface
{
    /**
     * @return string
     */
    public function getWarehouse(): string;

    /**
     * @return string
     */
    public function get3PL(): string;

    /**
     * @return int
     */
    public function getOwnerUserId(): int;
}
abstract class AbstractBuilder implements PackageBuilderInterface
{
    /**
     * @var array
     */
    protected $packages;

    /**
     * @var PackageBuilderInterface
     */
    private $builder;

    /**
     * Builder constructor.
     *
     * @param PackageBuilderInterface $builder
     */
    public function __construct(PackageBuilderInterface $builder = null)
    {
        $this->packages = [];
        $this->builder  = $builder;
    }

    /**
     * {@inheritdoc}
     */
    final public function getPackages(): array
    {
        $packages = $this->packages;
        if ($this->builder) {
            $packages = [];
            foreach ($this->packages as $package) {
                foreach ($package as $item) {
                    $this->builder->pack($item);
                }
                $fromSeller = $this->builder->getPackages();
                $packages   = array_merge(array_values($fromSeller), $packages);
            }
        }
        $this->packages = [];

        return $packages;
    }
}
class SellerClassifier extends AbstractBuilder
{
    /**
     * {@inheritdoc}
     */
    public function pack(PackageItemInterface $item)
    {
        $key = sprintf('%s_%s', $item->get3PL(), $item->getOwnerUserId());
        if (!isset($this->packages[$key])) {
            $this->packages[$key] = [];
        }
        $this->packages[$key][] = $item;
    }
}
class ThreePLClassifier extends AbstractBuilder
{
    /**
     * {@inheritdoc}
     */
    public function pack(PackageItemInterface $item)
    {
        $key = sprintf('%s_%s', $item->getWarehouse(), $item->get3PL());
        if (!isset($this->packages[$key])) {
            $this->packages[$key] = [];
        }
        $this->packages[$key][] = $item;
    }
}
class WarehouseClassifier extends AbstractBuilder
{
    /**
     * {@inheritdoc}
     */
    public function pack(PackageItemInterface $item)
    {
        if (!isset($this->packages[$item->getWarehouse()])) {
            $this->packages[$item->getWarehouse()] = [];
        }
        $this->packages[$item->getWarehouse()][] = $item;
    }
}

[kamranahmedse]

No it is fine. The example is not the exact implementation. To keep it simple, I did not implement the pay method in each of the classes and resorted to the one in the base class by just showing the class that was used for payment

echo sprintf('Paid %s using %s' . PHP_EOL, $amountToPay, get_called_class());

In real world, I could have overridden the pay method in each of the sub-classes and implemented it according to the payment provider.