Coder Social home page Coder Social logo

Comments (15)

infinisil avatar infinisil commented on June 9, 2024 3

But I do think that for the benefit of everybody's time, it would be best to archive other formatters if the RFC is accepted and implemented.

from alejandra.

viperML avatar viperML commented on June 9, 2024 3

After trying nixfmt-rfc-style, I have decided to keep using alejandra in my personal projects. My opinion is that it is ok to have different formatters to choose from, that don't comply with the "standard"

from alejandra.

kamadorueda avatar kamadorueda commented on June 9, 2024 2

It's probably a good question for the community once the RFC is adopted, the options are:

  1. make Alejandra follow the suggested style
  2. make Alejandra keep its existing style (there will always be an audience for this style)
  3. archive all alternative formatters so the community only has 1 option available

from alejandra.

justinrubek avatar justinrubek commented on June 9, 2024 2

As much as I'd love for us all to fall on a single standard, after trying out the new nixfmt I don't think I'm willing to use an RFC166 compliant formatter on any of my projects. I'd prefer that alejandra remain as it is currently.

from alejandra.

infinisil avatar infinisil commented on June 9, 2024 1

The main intention behind making it a standard is to not make the implementation the standard. This allows some room for both bug fixes and minor improvements, but it also makes it clear which changes need to go though another RFC.

And while Nixpkgs will have to use the official formatter, there's no problem with other standard-complient formatters existing. It would also be possible to change out the underlying implementation of the official formatter (as long as it's standards-compliant).

from alejandra.

nyabinary avatar nyabinary commented on June 9, 2024 1

But I do think that for the benefit of everybody's time, it would be best to archive other formatters if the RFC is accepted and implemented.

I disagree on this end, I think alejandra should adopt the standard, but some formatters, of course, can be archived like nixpkgs-fmt. Since that had one goal in mind, alejandra is more broad and widely used in the community (including myself) so I think its best to continue supporting it and change it to adhere to the RFC.

from alejandra.

MattSturgeon avatar MattSturgeon commented on June 9, 2024 1

We could have different modes tbf

Is anyone actually going to work on and maintain that when there's already alternative formatting tools out there?

It seems to me that alejandra has different goals to RFC 166. If so this should be considered a "won't fix".

from alejandra.

nyabinary avatar nyabinary commented on June 9, 2024

cc: @kamadorueda

from alejandra.

nyabinary avatar nyabinary commented on June 9, 2024

It's probably a good question for the community once the RFC is adopted, the options are:

1. make Alejandra follow the suggested style

2. make Alejandra keep its existing style (there will always be an audience for this style)

3. archive all alternative formatters so the community only has 1 option available

As I understand 3 is a non-goal, the formatter implementation is supposed to be considered more of a standard specification for formatting, so different implementations could exist as well, 1. Would be the most optimal.

from alejandra.

piegamesde avatar piegamesde commented on June 9, 2024

If adapting Alejandra to the RFC166 format was easy, I'd already have done so half a year ago. Initially, nixfmt was only our second choice after Alejandra.

from alejandra.

nyabinary avatar nyabinary commented on June 9, 2024

If adapting Alejandra to the RFC166 format was easy, I'd already have done so half a year ago. Initially, nixfmt was only our second choice after Alejandra.

What's wrong with Alejandra that makes it harder to adher to RFC0166?

from alejandra.

infinisil avatar infinisil commented on June 9, 2024

We recorded some meetings notes about that here

from alejandra.

nyabinary avatar nyabinary commented on June 9, 2024

Nix Formatter is now out for testing in nixpkgs.
https://discourse.nixos.org/t/call-for-testing-nix-formatter/39179/

from alejandra.

nyabinary avatar nyabinary commented on June 9, 2024

@kamadorueda
The time is now to decide I guess, since NixOS/rfcs#166 got officially merged, and their now a tracking issue for nixfmt: NixOS/nixfmt#153

from alejandra.

nyabinary avatar nyabinary commented on June 9, 2024

As much as I'd love for us all to fall on a single standard, after trying out the new nixfmt I don't think I'm willing to use an RFC166 compliant formatter on any of my projects. I'd prefer that alejandra remain as it is currently.

We could have different modes tbf

from alejandra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.