Coder Social home page Coder Social logo

Notification about animation end about gifu HOT 6 OPEN

kaishin avatar kaishin commented on May 28, 2024
Notification about animation end

from gifu.

Comments (6)

halonsoluis avatar halonsoluis commented on May 28, 2024 3

A user of your lib may want to use a gif as a part of a more complex flow, knowing when the animation has ended is a really cool and powerful feature.

from gifu.

andreabar avatar andreabar commented on May 28, 2024 3

I did something like this:

class CustomGIFImageView : UIImageView, GIFAnimatable {
    private let completionQueue = DispatchQueue(label: "com.myapp.gif-queue")
    private var completionBlock = {}
    
    func startAnimatingGIF(withCompletionHandler callback: @escaping () -> ()) {
        startAnimatingGIF()
        completionBlock = callback
        
        completionQueue.async {
            while(self.isAnimatingGIF) {}
            DispatchQueue.main.async {
                self.completionBlock()
            }
        }
    }
    
    /// A lazy animator.
    public lazy var animator: Animator? = {
        return Animator(withDelegate: self)
    }()
    
    /// Layer delegate method called periodically by the layer. **Should not** be called manually.
    ///
    /// - parameter layer: The delegated layer.
    override public func display(_ layer: CALayer) {
        updateImageIfNeeded()
    }

}

It works fine in my app

from gifu.

sharad-paghadal avatar sharad-paghadal commented on May 28, 2024 2

Worst solution @andreabar, while(self.isAnimatingGIF) {} this line of code will use CPU at 100%.

from gifu.

kaishin avatar kaishin commented on May 28, 2024

@alexth Currently the animation loops automatically. I am not sure I understand how is that not what you are after.

from gifu.

kaishin avatar kaishin commented on May 28, 2024

@halonsoluis Fair enough. I do not have time to work on features that I don't need but PRs would be very welcome.

from gifu.

andreabar avatar andreabar commented on May 28, 2024

I'm not using this library anymore and I know that running a loop (even if it has an empty body) every tick it's very CPU consuming.
One solution could be put the thread to sleep for some milliseconds (since the code is running on a queue that is not the main thread that should not be an issue).
It would reduce the CPU usage. However this could led to some delay after the moment when the animation ends and the completionBlock call.

I didn't find any better solution other than that.
Oh well, actually I did found a much better solution: Do not use GIF at all. There are some other very elegant ways to put something animated in a iOS app.

from gifu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.