Comments (15)
Under implementation Ideas I see add more global environment variables
. I don't agree with that, this should be something that schould be configurable by job/schedule IMHO. Because Resic's memory usage is very dependent on how many files it backs up. So a project with not many files to backup will need drastically less resources than a project with millions of files.
from k8up.
Yeah I wasn't sure about this. Please feel free to add your own ideas, you know K8up best :)
from k8up.
I'll take this one
from k8up.
I have refined this issue. @megian please review and add corrections or more acceptance criteria
from k8up.
Most is fine by me. I would just reword "I can optimize resource usage or comply with cluster resource policies" to "I can override the default request and limits of the namespace".
from k8up.
I have updated the summary
basically the "so that" clause should specify what we get out of it from a business perspective and less the technical reasons.
from k8up.
Well in this case this is very theoretic, because it's just a technical issue. K8up is just not usable without this under the cluster conditions. So we probably could write something like enable k8up run on multi tenant cluster allow a higher audience, but as long as I can override the resource and limits, I'm happy with the current wording as well.
from k8up.
I amended the implementation ideas with my ideas
from k8up.
@Kidswiss I have a question related to this sentence “we should have the ability to set the limits by job and schedule, where values can be overwritten like for the S3 endpoints”, do you mean we need a environment variable for the backup job and another one for the schedule (also per request/limit)?
from k8up.
I would do the defaults with environment variables.
I wouldn't do the overrides with them though. But rather in the CRDs. Create a new type like k8upResourceLimits
and include it in all the jobs and the schedule. Like the Backend
type. It exists for each job type as well as the schedule. This way we can specify backends for schedules as well as for single jobs. That's what I mean with that sentence :)
from k8up.
@Kidswiss ok, all clear now, thank you :)
from k8up.
@megian The PR is now merged and should work. The new feature is currently available in quay.io/vshn/k8up:master
image tag available
from k8up.
@ccremer When is an tagged release planned? I think as this is a production cluster, we don't want to set the deployment to a master or latest tag.
from k8up.
I don't have a clear date. There's a milestone for feature parity for the code that is currently released: https://github.com/vshn/k8up/milestone/1
However, I don't think we can finish the milestone in the next 2 weeks as-is, unless #129 is removed from that milestone, then we might make it.
@tobru WDYT?
from k8up.
I don't want to cut a release before we did more tests, so this most probably won't happen this year anymore.
from k8up.
Related Issues (20)
- Env variable BACKUP_GLOBALRESTORES3ACCESKEYID contains typo
- Allow using custom CA certificates HOT 2
- Support container Security Context HOT 1
- Improve external Contributor Experience
- Archive is Not Created HOT 1
- Include K8s objects in backup
- Failed backup stated as succeeded HOT 2
- Longhorn & Wordpress - k8up changes directory permission HOT 2
- Create PVC Backups via CSI Snapshots or CSI Cloned Volumes
- GCS backend only allows short lived token
- concurrentRunsAllowed: false is not working
- Fix typo in `RestServerSpec`
- Refactoring e2e test with kubernetes-sigs/e2e-framework
- Installation of CRD fails HOT 3
- Helm chart support dual stuck clusters
- Add easy way to create an backup instance of a schedule
- Helm Chart 4.5.1 hasn't been released to repositories HOT 4
- Allow to set the priorityClassName of Backup pods
- make run doesn't work
- getting started - Introduction Tutorial - ciphertext verification failed HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from k8up.