Coder Social home page Coder Social logo

Comments (5)

Kidswiss avatar Kidswiss commented on May 28, 2024 1

Well the first one isn't that bad. As the operator will clean up older jobs anyways. So the amount of CRs with the old status fields should die out rather quickly. For some clusters it's configured to keep no older Jobs at all.

from k8up.

ccremer avatar ccremer commented on May 28, 2024

I would also welcome this. Just adding conditions without removing/changing the existing ones is backwards compatible (e.g. we can just run the operator and after reconcile the existing objects will get the new conditions).
However, if we remove existing status fields from the CRD, would we need to make a new API version? (v1alpha2)
Maybe the K8s deserializer can ignore status fields that aren't expected in the CRD definition

from k8up.

ccremer avatar ccremer commented on May 28, 2024

I took the liberty to refine this feature request

from k8up.

Kidswiss avatar Kidswiss commented on May 28, 2024

Maybe the K8s deserializer can ignore status fields that aren't expected in the CRD definition

We can test this while implementing this I guess, by simply removing the old status fields, running the operator and see what happens.

from k8up.

ccremer avatar ccremer commented on May 28, 2024

I think it's the other way round: Remove the status fields from the CRD, update CRD, add/keep status fields in the YAML of an object, then run Operator. I expect either:

  1. The unknown status fields are left as-is, which would be kinda "bad", as they won't get cleaned
  2. The operator removes unknown status fields and only stores the one it knows

from k8up.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.