Mismatch between the network annotation in - K8s plumbing working group documentation and the implementation about multus-cni

[dougbtv]

Yep, this is definitely a mistake here, I don't think the version string got attached. Here's the sample pod I was working from:

apiVersion: v1
kind: Pod
metadata:
  name: bothpod
  annotations:
    kubernetes.cni.cncf.io/networks: macvlan-conf,flannel-conf
spec:
  containers:
  - name: bothpod
    command: ["/bin/bash", "-c", "sleep 2000000000000"]
    image: dougbtv/centos-network
    ports:
    - containerPort: 80

And that pod really needs to be...

apiVersion: v1
kind: Pod
metadata:
  name: bothpod
  annotations:
    kubernetes.v1.cni.cncf.io/networks: macvlan-conf,flannel-conf
spec:
  containers:
  - name: bothpod
    command: ["/bin/bash", "-c", "sleep 2000000000000"]
    image: dougbtv/centos-network
    ports:
    - containerPort: 80

I'll submit a fix for this one -- thanks for the eyes Kural! (I also left a comment on the spec in response to yours, too.

[rkamudhan]

@dougbtv @s1061123 : I think, we have to change the documentation for it.

[rkamudhan]

Thanks @dougbtv

[rkamudhan]

@s1061123 @dougbtv Creating a patch for it along with k8s-client package

[dougbtv]

Kural, cool if you have it in the dev/nwpg-crd-changes-k8s-client-feature branch -- that's good, otherwise, I'd wait until that change is complete because it moves all that logic to a new file. I just previewed that branch, looks good, and thanks for kicking that off.

[rkamudhan]

#58 Fixed in the PR