include "attachment" (t) stream for fonts about video2x

[cr08]

As a suggestion it may be simpler to go to the command line options I used in the following comment or some equivalent: #24 (comment) Essentially it should copy all streams over from the input file regardless of type and just ignore the original video stream (since we are upscaling and providing a new copy of course). I'm not sure if there's any reason we should potentially be ignoring certain streams and not just keeping the original intact 1:1 save for the upscaled video.

[k4yt3x]

@cr08 ok. I'll follow your suggestions and try it out.

[k4yt3x]

I have made a test with your solution, but it didn't seem to copy anything over besides the video stream.

-map 1:v:0 -map 0 -c copy -map -0:v

[cr08]

I had a look through again and it may be the input videos are flipped around in the ffmpeg command. Right now the no_audio.mp4 is coming first. So either the above options need to be flipped to

-map 0:v:0 -map 1 -c copy -map -1:v

or flip around the input -i parameters so the no_audio.mp4 comes second.

I'm running a quick test on my end to confirm.

[k4yt3x]

Oops you're right. I changed it to

-map 0:v:0? -map 1? -c copy -map -1:v?

I don't know if it's necessary to add the ?s, is it?
Everything is looking good right now though. All streams have been copied over.

[cr08]

Theoretically the question marks shouldn't be needed. Based on how I am reading the documentation it is only necessary if there is a possibility of that map not existing so the command doesn't outright fail, it just ignores that map.

-map 0:v:0?
^ We know the input video track is going to exist there from the no_audio.mp4 file

-map 1?
^ We know the source input file should still exist at this stage and the map is just saying to grab everything regardless of track type. The only POTENTIAL issue I could see is if someone deletes the input file mid-way through running the script but I don't know why they would?

-map -1:v?
^ Much like the last map, the original source file we know should have a video track that needs to be cancelled out.

With that all said there's nothing harmful leaving the question marks in there, just extraneous characters.

[cr08]

And confirmed on my end that swapping those around works just fine with my test content.

[k4yt3x]

Changes committed. It should be working now.