Coder Social home page Coder Social logo

Comments (7)

k4yt3x avatar k4yt3x commented on August 12, 2024 1

Oh yeah I should add the function to create folders automatically if they're missing.
I'll add that into the next commit and push it with the fix for #28 .

from video2x.

k4yt3x avatar k4yt3x commented on August 12, 2024 1

Maybe you can set "preserve_frames" to true in the config file?
That might be the cheapest solution to this problem for now.

I'll look into adding an option for it, or make changes that will make this problem go away.
Also, please open a new issue as this is a separate topic from the original one. Opening a new issue also helps organizing my work.

from video2x.

k4yt3x avatar k4yt3x commented on August 12, 2024

I saw your code review, and I've already finished adding the features.
I came up with something more complicated and fault-tolerant.
I'll just make some more tests before releasing the new version.

from video2x.

k4yt3x avatar k4yt3x commented on August 12, 2024

I have just released version 2.4.2.
Problem should be solved.

from video2x.

cr08 avatar cr08 commented on August 12, 2024

One minor addition to this to request: Adding either a command line or config option to skip the "Create folder/directory?" request. Currently this breaks batching the script when intending to use custom paths.

from video2x.

k4yt3x avatar k4yt3x commented on August 12, 2024

By design, if you have the destination folder created, it shouldn't prompt you. Is it not working properly?

from video2x.

cr08 avatar cr08 commented on August 12, 2024

Part of the original concern is there in which regardless of whether the temp folders are used or custom paths, they are deleted at the tail end of the script. Specifically this section of code:

https://github.com/K4YT3X/video2x/blob/ecb65aad35e51490e160af272084831368576891/bin/upscaler.py#L72-L80

So I can create the custom folders I wish to use for extracted and upscaled frames, but when the script finishes it will delete these outright and the next cycle it will ask to create those because they no longer exist.

from video2x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.