Coder Social home page Coder Social logo

Comments (1)

cjellick avatar cjellick commented on June 11, 2024

In our meeting, we also talked about some implementation details that needed changed. Just capturing them here so they dont get lost:

  • Add NewFactoryFromConfigWithNamespace helper method to wrangler and use it to run the controller either against all NSes or just 1 namespace. Passing a "" to this function as the namespace parameter should be interpreted as run against all namesapces
  • In the thing that calls Register (I think), you had variables named JobController and HelmChartController (or something like that). They arent controllers they are factories and their names should reflect that
  • Get rid of the types directory and move its two sub-dirs under pkg
  • Make sure you have StrictCaching and WithSetID on your Apply, but move all of the specifics added to Apply to inside of Register so that the one passed in can be completely generic
  • In your unit test, you might have to create a custom "Apply" implementation

from helm-controller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.