Comments (1)
In our meeting, we also talked about some implementation details that needed changed. Just capturing them here so they dont get lost:
- Add NewFactoryFromConfigWithNamespace helper method to wrangler and use it to run the controller either against all NSes or just 1 namespace. Passing a "" to this function as the namespace parameter should be interpreted as run against all namesapces
- In the thing that calls Register (I think), you had variables named JobController and HelmChartController (or something like that). They arent controllers they are factories and their names should reflect that
- Get rid of the types directory and move its two sub-dirs under pkg
- Make sure you have StrictCaching and WithSetID on your Apply, but move all of the specifics added to Apply to inside of Register so that the one passed in can be completely generic
- In your unit test, you might have to create a custom "Apply" implementation
from helm-controller.
Related Issues (20)
- Support multiple HelmChartConfig HOT 2
- Klipper is unable to upgrade chart with PDB HOT 12
- v13.3 not released for amd64 HOT 2
- Helm Controller is constantly requeuing deployments HOT 8
- repoCA as a secret reference HOT 4
- modified helm install-job using the k8s dynamic admission controller by injecting some custom labels and annotations into it, causing the Helm Controller is error syncing constantly requeuing HOT 2
- RBAC needed for namespaced deployment HOT 3
- Support set from HelmChartConfig HOT 1
- Fix missing escape for IPv6 support. HOT 4
- How to install the klipper helm chart HOT 2
- Missing documentation for HelmChart and other API objects HOT 3
- Feature: Allow set default job image via env var HOT 4
- No status in HelmChart can reflect the deploying status of a chart HOT 3
- FR: Add `spec.values` to the HelmChart CRD for structured YAML support HOT 10
- IPv6 cluster bootstrap failure HOT 7
- Add option to generate CRD HOT 1
- HelmChart is not passing the --caFile arg with repoCAConfigMap is set HOT 1
- Job image pull secrets
- Bootstrap failing with IPv6 only Cluster HOT 1
- Invalid chart name on install HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helm-controller.