'-DHAVE_PMSDR' breaks building about swradio-8

[JvanKatwijk]

Your interpretation is correct it is either or Op vr 26 aug. 2022 om 18:02 schreef Gisle Vanem ***@***.***>:

…

Building for PMSDR (yes, I have one of these) break the build big-time since radio.cpp has this: #ifdef HAVE_EXTIO #include "extio-handler.h" #elif HAVE_PMSDR #include "pmsdr-handler.h" #else #ifdef HAVE_SDRPLAY #include "sdrplay-handler.h" #endif ... Note the #else part. No header past that point gets included. So is PMSDR support supposed to be built with no other devices? AFAICS it should be: --- a/radio.cpp 2022-08-26 11:58:26+++ b/radio.cpp 2022-08-26 17:56:02@@ -46,9 +46,10 @@ #include "filereader.h" #ifdef HAVE_EXTIO #include "extio-handler.h"-#elif HAVE_PMSDR+#endif+#ifdef HAVE_PMSDR #include "pmsdr-handler.h"-#else+#endif #ifdef HAVE_SDRPLAY #include "sdrplay-handler.h" #endif What a joke. — Reply to this email directly, view it on GitHub <#16>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCPHQAJJ4G3X6BSWFFDCN3V3DTBDANCNFSM57XHM7FQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Jan van Katwijk

[gvanem]

So explain this then:

static
const char *deviceTable [] = {
	D_WAV_FILE,
#ifdef	HAVE_SDRPLAY
	D_SDRPLAY,
#endif
#ifdef	HAVE_SDRPLAY_V3
	D_SDRPLAY_V3,
#endif
#ifdef	HAVE_HACKRF
	D_HACKRF,
#endif
#ifdef	HAVE_RTLSDR
	D_RTLSDR,
#endif
#ifdef	HAVE_RTL_TCP
	D_RTL_TCP,
#endif
#ifdef	HAVE_PMSDR
	D_PMSDR,
#endif
#ifdef	HAVE_EXTIO
	D_EXTIO,
#endif
	nullptr
};

No #else part here.

[JvanKatwijk]

software is made available "as is" feel free to apart to your own needs nut stop asking about tribialities Op vr 26 aug. 2022 om 20:02 schreef Gisle Vanem ***@***.***>:

…

So explain this then: staticconst char *deviceTable [] = { D_WAV_FILE, #ifdef HAVE_SDRPLAY D_SDRPLAY, #endif #ifdef HAVE_SDRPLAY_V3 D_SDRPLAY_V3, #endif #ifdef HAVE_HACKRF D_HACKRF, #endif #ifdef HAVE_RTLSDR D_RTLSDR, #endif #ifdef HAVE_RTL_TCP D_RTL_TCP, #endif #ifdef HAVE_PMSDR D_PMSDR, #endif #ifdef HAVE_EXTIO D_EXTIO, #endif nullptr }; No #else part here. — Reply to this email directly, view it on GitHub <#16 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCPHQF4S6BHKKGEIY5I6R3V3EBA5ANCNFSM57XHM7FQ> . You are receiving this because you commented.Message ID: ***@***.***>

-- Jan van Katwijk