Coder Social home page Coder Social logo

Comments (5)

bgiori avatar bgiori commented on August 22, 2024

1 second seems very short for a timeout. I think we should bump the timeout for all operations. Maybe something ~5s?

from mcumgr-android.

philips77 avatar philips77 commented on August 22, 2024

This should work for all current devices, but may also be parametrised. At least in the transport interface an additional parameter with timeout? Or not worth changing the API?

from mcumgr-android.

bgiori avatar bgiori commented on August 22, 2024

I think it would be best to leave it up to the transport implementation. It could be nice to expose the timeout through the interface, but I cant think of a good use case as of now, so it may be more cluttering than what it's worth. For now I think we should:

  1. Parameterize timeout in McuMgrBleTransport with getter/setter
  2. Bump the timeout from 1s to 4-5s

from mcumgr-android.

philips77 avatar philips77 commented on August 22, 2024

True. Let's do 2. then.

from mcumgr-android.

bgiori avatar bgiori commented on August 22, 2024

Fixed in ceca338

from mcumgr-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.