Comments (6)
Hey @ljharb, this issue is super old and PouchDB has actually since implemented an aggressive object-cloning logic in order to work around subtle IndexedDB issues, so it's probably not even reproducible anymore. I dunno what the status of Ember is.
I'm happy just to close this issue! :)
from node-extend.
I'd file that on Ember - modifying global prototypes (outside of a spec-compliant shim) is pure insanity, and the instant a lib does it, all bets are off.
Does Ember use node-extend?
from node-extend.
However, if you can provide a PR that doesn't break this functionality but makes it more robust in a crazy irresponsible prototype-modifying world, I'll be happy to merge it in :-)
from node-extend.
Yeah, that's exactly what I suspect I don't have the patience to do. :) In any case, yeah, the fault is really on Ember for modifying the prototype (tisk tisk!), although they probably had a good reason for it, since they need some way to observe objects without Object.observe.
from node-extend.
I'm no longer checking for nodeType
or setInterval
here, so can you give this another try with v2.0.0
?
from node-extend.
@nolanlawson ping
from node-extend.
Related Issues (20)
- ReferenceError: isPlainObject is not defined HOT 5
- Usage in the readme could be more explicit HOT 4
- why the isArray stuff? HOT 1
- Consider not filtering out properties that are explicitely set to undefined HOT 7
- Difference between extend and Object.assign? HOT 1
- Cannot read config file: node_modules/extend/.eslintrc HOT 6
- update eslint rules HOT 3
- .eslintrc has invalid duplicate setting from npm HOT 3
- Publish most recent changes HOT 2
- Should unify the 'target' arg's protection HOT 1
- Assignment in if statement HOT 1
- Package contains file not is source control HOT 4
- Support for symbols as keys HOT 6
- Changed default branch name to "main" HOT 1
- invalid json syntax in eslintrc file HOT 1
- Security concern HOT 2
- depends on 'extend'. CommonJS or AMD dependencies can cause optimization bailouts. HOT 1
- Provide esm version HOT 3
- Prototype pollution in index.js HOT 1
- Vite Struggles with Exports HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-extend.