Coder Social home page Coder Social logo

Comments (6)

nolanlawson avatar nolanlawson commented on August 15, 2024 1

Hey @ljharb, this issue is super old and PouchDB has actually since implemented an aggressive object-cloning logic in order to work around subtle IndexedDB issues, so it's probably not even reproducible anymore. I dunno what the status of Ember is.

I'm happy just to close this issue! :)

from node-extend.

ljharb avatar ljharb commented on August 15, 2024

I'd file that on Ember - modifying global prototypes (outside of a spec-compliant shim) is pure insanity, and the instant a lib does it, all bets are off.

Does Ember use node-extend?

from node-extend.

ljharb avatar ljharb commented on August 15, 2024

However, if you can provide a PR that doesn't break this functionality but makes it more robust in a crazy irresponsible prototype-modifying world, I'll be happy to merge it in :-)

from node-extend.

nolanlawson avatar nolanlawson commented on August 15, 2024

Yeah, that's exactly what I suspect I don't have the patience to do. :) In any case, yeah, the fault is really on Ember for modifying the prototype (tisk tisk!), although they probably had a good reason for it, since they need some way to observe objects without Object.observe.

from node-extend.

ljharb avatar ljharb commented on August 15, 2024

I'm no longer checking for nodeType or setInterval here, so can you give this another try with v2.0.0?

from node-extend.

ljharb avatar ljharb commented on August 15, 2024

@nolanlawson ping

from node-extend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.