Bad looking subtitle font - linux about tsmuxer

[jcdr428]

@darekpro yes this is the same for Windows. We might look at this in the future, in the meantime you can convert your srt to BD sup with easySUP which works very well.

[jcdr428]

@darekpro Just to be sure... this is the build https://github.com/jcdr428/tsMuxer/suites/406472859/artifacts/1185098

[jcdr428]

@darekpro new try... https://github.com/jcdr428/tsMuxer/suites/417185880/artifacts/1305874

[jcdr428]

@darekpro what's the name of these fonts giving bad results ?

[jcdr428]

@darekpro so it is not perfect but definitely looking better ;)

[jcdr428]

@darekpro hopefully with this one, it will look even better https://github.com/jcdr428/tsMuxer/suites/417290642/artifacts/1307079

[justdan96]

Nice to see some progress!

[justdan96]

Is this an issue with the kerning or something? Can we try it out with a few different fonts to check it is an issue with the renderer?

[jcdr428]

@justdan96 Windows version doesn't use freetype, but seems to me that in textSubtitlesRenderFT.cpp :
line 588 pen.x += face->glyph->advance.x >> 6;
line 593 mSize->cx = pen.x + face->glyph->bitmap_left;

the glyph left side bearing bitmap_left is already included in advance.x so is added twice.
Try change to mSize->cx = pen.x;
Same for line 540.

Edit: same for the underline thickness m_line_thickness, I can't see why it would need to be added to the horizontal advance.

[jcdr428]

@darekpro please try my latest build https://github.com/jcdr428/tsMuxer/actions and report.
I haven't tried it as I am on Windows.

[darekpro]

Hmm I don't see any difference still problem with space between letters, no shadow and bad looking edges

[darekpro]

Helvetica font

[justdan96]

I wonder what happens if you use a fixed width font like GNU Freefont Mono?

[jcdr428]

@darekpro thanks. Could you please try latest build (88b9561) https://github.com/jcdr428/tsMuxer/actions

[darekpro]

@jcdr428 one sec

[jcdr428]

@darekpro this is the latest build 88b9561 ? It was created only 7 min. ago.

[darekpro]

No no this is screen with mono fonts :)

[darekpro]

@jcdr428 you know what.. I use pamac to rebuild tsmuxer and you change not main repo right? I dont know how to manual build .. ;/

[justdan96]

You could edit the PKGBUILD yourself and then run makepkg - or try the binary made in output of the GitHub Actions on @jcdr428's repo.

[darekpro]

How :) ?

[jcdr428]

So all these pictures were not my build ?
Just go to https://github.com/jcdr428/tsMuxer/actions , click on the top "Build for linux", click on "Artifacts" at the top right, download "tsMuxer"

[darekpro]

Yes sorry... I downloaded pack from here https://bintray.com/justdan96/tsMuxer/tsMuxerGUI-Nightly/2020-01-17--01-10-08#files and replaced file from https://github.com/jcdr428/tsMuxer/actions
I hope I use now latest version :)

[darekpro]

Yes :)

[darekpro]

progress :)

[darekpro]

I use Helvetica looks good

[darekpro]

Now much better!

So one problem less but still no shadows and I noticed also problem with color change:


transparent wtf :)

[jcdr428]

@darekpro what "Color" number have you entered in your example ? If you have entered e.g. #b1b2b3b4, the first three digits b1 b2 b3 are the Red Green Blue values, and the last one b4 is the transparency -which should remain ff if you want 100% opacity.

[darekpro]

I don't enter numbers i just use slide bar like on screen
I used this color:

[darekpro]

check this one

[justdan96]

It looks like to enable transparency for QColorDialog we need to use QColorDialog::ShowAlphaChannel.

So for that I believe we could change this line:

tsMuxer/tsMuxerGUI/tsmuxerwindow.cpp

Line 1884 in 0702a4b

color = QColorDialog::getColor(color, this);

To:

color = QColorDialog::getColor(color, this, QString("Select Color"), QColorDialog::ShowAlphaChannel);

[jcdr428]

@justdan96 actually there is already transparency on the subtitles. But the transparency is applied on the whole subtitle instead of being applied on the outer border only.

[justdan96]

Oh I thought the alpha slider was missing from the dialog.

[justdan96]

Should we leave this one open to track remaining issues with subtitles or is this a "good enough" fix?

[jcdr428]

@justdan96 The fix has solved the irregular spacing between letters. It hasn't solved the lack of border or transparency problem raised by darekpro.
Maybe we can close this issue and open a specific one for border/transparency.

[justdan96]

Will close this one, if anyone is still concerned they can create a new issue for the border and transparency visual.