Coder Social home page Coder Social logo

Comments (7)

jdpurcell avatar jdpurcell commented on June 9, 2024 1

Similar issues: #638, #603

from qview.

brian6932 avatar brian6932 commented on June 9, 2024 1

Ah I wasn't aware of your fork, nice

from qview.

brian6932 avatar brian6932 commented on June 9, 2024 1

2 enables full dark mode support.

Ah yes that works, nice

from qview.

brian6932 avatar brian6932 commented on June 9, 2024

A little off topic, but any idea why your fork (and #666) doesn't theme the titlebar anymore?
I have

$env:QT_QPA_PLATFORM
windows:darkmode=1

and it works on the nightly version used here which was built on Qt 6.2.2.
It may be specifically related to the Qt version you're using, as I've built programs with Qt >= 6.6.0 and they still theme the titlebar.

I tried this artifact for a different Qt version https://github.com/jdpurcell/qView/actions/runs/8040054619 and it also exhibits it.

from qview.

jdpurcell avatar jdpurcell commented on June 9, 2024

I don't know, I'll have to see if I can reproduce it sometime. I'm mostly using macOS these days honestly. I know Qt has been working on dark mode on Windows and maybe they're forcing use of Fusion style to get the dark titlebar. Fusion style is the "Non-native theme" option in my fork by the way.

from qview.

brian6932 avatar brian6932 commented on June 9, 2024

they're forcing use of Fusion style to get the dark titlebar

Nah, Windows can have native dark titlebars, within DWM itself (DWMWA_USE_IMMERSIVE_DARK_MODE), Qt's supported this feature for a few years now.

Fusion style is the "Non-native theme" option in my fork

Yea I noticed fusion mode on your fork, and tried it, but wasn't able to get dark mode to work, it was just light mode, is there some separate toggle or something?


Side note, I'm down to build qView if it helps for debugging this issue, but need to refresh on qmake and .pro again, has been a few years since I last used that, Qt >= 6.0.0 uses cmake as default nowadays.

from qview.

jdpurcell avatar jdpurcell commented on June 9, 2024

... any idea why your fork (and #666) doesn't theme the titlebar anymore?

I can reproduce this - I was testing by passing the command line argument -platform windows:darkmode=1 and got the dark title bar with Qt 6.2 but light title bar with Qt 6.5. But as I understand from Qt's blog entry and the commit here, that was an intentional change - Qt will now only use the dark title bar if the window background color is darker than the text color in the "default palette" (whatever that means).

Yea I noticed fusion mode on your fork, and tried it, but wasn't able to get dark mode to work, it was just light mode, is there some separate toggle or something?

It's because of that darkmode=1 setting apparently, 1 means just for the window frame (when allowed by the previously mentioned logic), and 2 enables full dark mode support.

from qview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.