Coder Social home page Coder Social logo

Comments (12)

SylvainCorlay avatar SylvainCorlay commented on June 21, 2024

Another option would be to have each extension app decide whether they allow other server extensions or not when they are used as the main extension point.

from jupyter_server.

rolweber avatar rolweber commented on June 21, 2024

I thought that the selected app is responsible for enabling all extensions that should be running, besides the default stuff that comes with Jupyter Server itself. So if the Voila extension doesn't enable Lab, then Lab isn't there. Am I mistaken there?

from jupyter_server.

vidartf avatar vidartf commented on June 21, 2024

Ideally, I would like to have the voila command line to become an alias on jupyter voila.

Just for context, what is the motivation for this?

from jupyter_server.

SylvainCorlay avatar SylvainCorlay commented on June 21, 2024

Just for context, what is the motivation for this?

This would reduce the number of entry points and simplify the codebase (e.g. no need for a VoilaConfiguration object).

from jupyter_server.

SylvainCorlay avatar SylvainCorlay commented on June 21, 2024

In a way, voila and lab are two perfect examples of extension apps...

from jupyter_server.

Zsailer avatar Zsailer commented on June 21, 2024

In the current ExtensionApp class, VoilaConfiguration already goes away (I desperately need to add documentation to demonstrate this).

In PR #59, I added logic to handle the extension-specific config. That way, extensions writers don't need to write their own mixin classes (like VoilaConfiguration).

How does this work?

  • ExtensionApp creates a Configurable object to store the extension's trait
  • It then passes this object to tornado web-servers settings under the '<extension_name>_config' key.
  • If the extensions' handlers inherit the provided ExtensionHandler class, this object is accessible under the handler's self.config attribute.

from jupyter_server.

Zsailer avatar Zsailer commented on June 21, 2024

I'm also fine with adding a --standalone mode.

from jupyter_server.

SylvainCorlay avatar SylvainCorlay commented on June 21, 2024

In the current ExtensionApp class, VoilaConfiguration already goes away (I desperately need to add documentation to demonstrate this).

Yep, but I guess this requires the voila command line to be an alias on jupyter voila.

I'm also fine with adding a --standalone mode.

👍

from jupyter_server.

Zsailer avatar Zsailer commented on June 21, 2024

Yep, but I guess this requires the voila command line to be an alias on jupyter voila.

I think you're right.

You could, instead, have a small subclass that inherits the Voila ExtensionApp, changes the standalone trait to True, set this trait's tag config=False, and add a new voila entry-point pointing to this classes launch_instance method.

from jupyter_server.

Zsailer avatar Zsailer commented on June 21, 2024

Adding in #70

from jupyter_server.

Zsailer avatar Zsailer commented on June 21, 2024

We added the option for ExtensionApps to shut off other extensions in #76

from jupyter_server.

Zsailer avatar Zsailer commented on June 21, 2024

Closing since we added standalone mode in #76.

from jupyter_server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.