Comments (2)
@ellisonbg Some questions / consideration raised based on the discussion with @3coins and @dlqqq:
- Editable fields. Which
Job Definition
fields should be editable?
- From API/backend perspective, any
Job Definition
field can be edited - Clarified ✅: as a 1st step only Scheduling-related fields
Schedule
andTimezone
are expected to be editable
- (✅ proceed with this option 3) User flow needs validation/approval. Proposed user flow:
- Option 1 (I think works best if all/majority of fields can be edited): add
Edit
button toJob Definition Detail
button bar. When it is clicked, editable text fields become editable and button changes toSave
. WhenSave
is clicked, text fields become uneditable, changes toJob Definition
are sent to the server and updatedJob Definition Detail
is shown - Option 2: if only 2 fields out of 9 can be edited, add small
Edit
/Save
buttons/links aboveSchedule
andTimezone
fields. - Option 3 (as described in #172 ): create new element, Job Form that would be used by both Detail View and Create Job. Job Form would have 2 modes: view and edit where view mode would be used in Detail View and edit view would be used in Create Job and when you click ‘Edit’ in Detail View . This option requires biggest refactoring but it would optimize the structure and control flow of application, reduce code duplication
- Add
Edit
icon toJob Definition List
icon bar. On click,Job Definition Detail
in edit mode (with editable text fields described above opens up
(Issue to consider: we need to effectively differentiate editable vs read-only fields. Currently all fields in Detail View are read-only meaning you can't edit them but they look (in terms of styling) and behave (in terms of interactions) as usual input fields; see #173 for proposed solution)
- (Done ✅) Showing
Advanced options
inJob Definition Detail
: currentlyAdvanced Options
are only shown at the bottom ofJob Detail
page. At the same time, as mentioned by @3coins, fields provided toAdvanced Options
might be / are meaningful forJob Definition Detail
page too, especially ifJob Definition
can be edited as user might need to editAdvanced Options
forJob Definition
too. Created issue #160 to track this and facilitate discussion around it - The advanced options inputs will / might still be editable in the detail view. Editable/read-only state of
Jobs Definition
should also extend to edit-ability / read-only state ofAdvancedOptions
displayed on the page (as mentioned by @dlqqq in #164). Created #165 to track this
from jupyter-scheduler.
From 10/20/2022 standup: Start with schedule and timezone being editable, add other fields afterwards upon receiving more user feedback.
from jupyter-scheduler.
Related Issues (20)
- Input Path with Prefix "RTC:" breaking functionality HOT 1
- Hide input code from output files created through Scheduler HOT 1
- Duplicate a job definition
- Telemetry HOT 2
- Why do we use Multiprocessing.Process to execute notebook HOT 1
- RuntimeError: "This event loop is already running" with nbclient==0.8.0 HOT 17
- No such kernel named conda-env-root_tf_2.13.0-py when using mamba
- Queue of jobs with max concurrency HOT 1
- On Safari browser, the jobs section for in JobDefintion page is not visible HOT 7
- New jobs always show up as "Stopped" on Linux
- add unit testing on Linux that runs jobs
- Delete job button is calling the delete API twice
- Output files open path error (%5C instead of backslash issue) HOT 2
- Ability to Prevent Saving Copies of Notebooks on Scheduled runs. HOT 1
- Better issue guidance for new users
- Extend Jupyter-scheduler to create and manage jobs with multiple tasks HOT 2
- Ability to associate kernelspec with a jobdefinition
- Emit telemetry events on create job forms HOT 2
- Scheduler not working despite being installed and enabled HOT 7
- Scheduled job executing more than 1 time HOT 27
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jupyter-scheduler.