Coder Social home page Coder Social logo

Comments (2)

andrii-i avatar andrii-i commented on June 29, 2024

@ellisonbg Some questions / consideration raised based on the discussion with @3coins and @dlqqq:

  1. Editable fields. Which Job Definition fields should be editable?
  • From API/backend perspective, any Job Definition field can be edited
  • Clarified ✅: as a 1st step only Scheduling-related fields Schedule and Timezone are expected to be editable
  1. (✅ proceed with this option 3) User flow needs validation/approval. Proposed user flow:
  • Option 1 (I think works best if all/majority of fields can be edited): add Edit button to Job Definition Detail button bar. When it is clicked, editable text fields become editable and button changes to Save. When Save is clicked, text fields become uneditable, changes to Job Definition are sent to the server and updated Job Definition Detail is shown
  • Option 2: if only 2 fields out of 9 can be edited, add small Edit / Save buttons/links above Schedule and Timezone fields.
  • Option 3 (as described in #172 ): create new element, Job Form that would be used by both Detail View and Create Job. Job Form would have 2 modes: view and edit where view mode would be used in Detail View and edit view would be used in Create Job and when you click ‘Edit’ in Detail View . This option requires biggest refactoring but it would optimize the structure and control flow of application, reduce code duplication
  • Add Edit icon to Job Definition List icon bar. On click, Job Definition Detail in edit mode (with editable text fields described above opens up

(Issue to consider: we need to effectively differentiate editable vs read-only fields. Currently all fields in Detail View are read-only meaning you can't edit them but they look (in terms of styling) and behave (in terms of interactions) as usual input fields; see #173 for proposed solution)

  1. (Done ✅) Showing Advanced options in Job Definition Detail: currently Advanced Options are only shown at the bottom of Job Detail page. At the same time, as mentioned by @3coins, fields provided to Advanced Options might be / are meaningful for Job Definition Detail page too, especially if Job Definition can be edited as user might need to edit Advanced Options for Job Definition too. Created issue #160 to track this and facilitate discussion around it
  2. The advanced options inputs will / might still be editable in the detail view. Editable/read-only state of Jobs Definition should also extend to edit-ability / read-only state of AdvancedOptions displayed on the page (as mentioned by @dlqqq in #164). Created #165 to track this

from jupyter-scheduler.

dlqqq avatar dlqqq commented on June 29, 2024

From 10/20/2022 standup: Start with schedule and timezone being editable, add other fields afterwards upon receiving more user feedback.

from jupyter-scheduler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.