Coder Social home page Coder Social logo

Comments (19)

lbustelo avatar lbustelo commented on June 3, 2024

@zackmorris is looking into this

from declarativewidgets.

lbustelo avatar lbustelo commented on June 3, 2024

The priorities of this issue whould be as follow:

  1. Enable the use of a Python 2.7+ kernel
  2. Enable Python unit tests to run on Python 2.7
  3. Verify that there is nothing Python 3 related being used on our import server extension (Modify accordingly)
  4. Installation of our package on a Python 2 install of Jupyter (setup.py)
  5. Modify our Makefile to allow running relevan targets (dev, server, install) with Python 3 or 2 support
  6. Modify travis setup to run System Tests on top of both Python versions

from declarativewidgets.

thibaudh avatar thibaudh commented on June 3, 2024

That is very helpful. Any guess for the number of man-days to accomplish all this?

On Nov 10, 2015, at 7:00 AM, Gino Bustelo [email protected] wrote:

The priorities of this issue whould be as follow:

  1. Enable the use of a Python 2.7+ kernel
  2. Enable Python unit tests to run on Python 2.7
  3. Verify that there is nothing Python 3 related being used on our import server extension (Modify accordingly)
  4. Installation of our package on a Python 2 install of Jupyter (setup.py)
  5. Modify our Makefile to allow running relevan targets (dev, server, install) with Python 3 or 2 support
  6. Modify travis setup to run System Tests on top of both Python versions


Reply to this email directly or view it on GitHub #50 (comment).

from declarativewidgets.

lbustelo avatar lbustelo commented on June 3, 2024

I'm hoping we get this before the end of the week.

Gino B.

On Nov 10, 2015, at 11:23 AM, Thibaud [email protected] wrote:

That is very helpful. Any guess for the number of man-days to accomplish all this?

On Nov 10, 2015, at 7:00 AM, Gino Bustelo [email protected] wrote:

The priorities of this issue whould be as follow:

  1. Enable the use of a Python 2.7+ kernel
  2. Enable Python unit tests to run on Python 2.7
  3. Verify that there is nothing Python 3 related being used on our import server extension (Modify accordingly)
  4. Installation of our package on a Python 2 install of Jupyter (setup.py)
  5. Modify our Makefile to allow running relevan targets (dev, server, install) with Python 3 or 2 support
  6. Modify travis setup to run System Tests on top of both Python versions


Reply to this email directly or view it on GitHub #50 (comment).


Reply to this email directly or view it on GitHub.

from declarativewidgets.

parente avatar parente commented on June 3, 2024

If it helps, the PR jupyter/dashboards#122 has all the Makefile changes needed to test, dev, and install against both Python 2 and 3. (Steps 4 and 5 above). There was only one Python 2.7 compatibility problem in the rest of the code as far as we know so far.

from declarativewidgets.

lbustelo avatar lbustelo commented on June 3, 2024

Here are the list of problems we are trying to solve:

  • urth-import NB server extension is using concurrent.futures
  • python unit tests that yield Syntax Errors due to use of function annotations.
  • Used of introspection in urth-core-function support
  • Syntax use for metaclasses in serialization code
  • Some of our examples might need changes
  • Update README with Python 2 support

from declarativewidgets.

lbustelo avatar lbustelo commented on June 3, 2024

Some good info here

from declarativewidgets.

lbustelo avatar lbustelo commented on June 3, 2024

We were able to fix the import support by using https://pypi.python.org/pypi/futures

from declarativewidgets.

lbustelo avatar lbustelo commented on June 3, 2024

@parente What are your thoughts on requiring https://pypi.python.org/pypi/futures to work on Python 2.7?

from declarativewidgets.

parente avatar parente commented on June 3, 2024

Seems reasonable if it works. The only other option I can think of is to use Tornado's async subprocess module, which I think @zackmorris attempted originally.

from declarativewidgets.

lbustelo avatar lbustelo commented on June 3, 2024

Going with requiring pip install futures==3.0.3

from declarativewidgets.

lbustelo avatar lbustelo commented on June 3, 2024

@thibaudh #95 just passed all test. We want to give it another look on Monday, but I would appreciate if you can give it a try and give us any feedback.

from declarativewidgets.

thibaudh avatar thibaudh commented on June 3, 2024

Great. I will test it on Monday.

Thibaud

On Nov 13, 2015, at 3:48 PM, Gino Bustelo [email protected] wrote:

@thibaudh https://github.com/thibaudh #95 #95 just passed all test. We want to give it another look on Monday, but I would appreciate if you can give it a try and give us any feedback.


Reply to this email directly or view it on GitHub #50 (comment).

from declarativewidgets.

thibaudh avatar thibaudh commented on June 3, 2024

When running setup.py install, I got the following error:

tbh@Thibauds-MacBook-Pro:~/graphistry/declarativewidgets$ python setup.py install
Traceback (most recent call last):
  File "setup.py", line 17, in <module>
    with open(os.path.join(HERE, 'urth/widgets/ext/_version.py')) as f:
IOError: [Errno 2] No such file or directory: '/Users/tbh/graphistry/declarativewidgets/urth/widgets/ext/_version.py’

I am on commit cbdba0a. Did the install procedure change? I used to do make sdist followed by setup.py install

Thibaud

On Nov 13, 2015, at 4:40 PM, Thibaud Hottelier [email protected] wrote:

Great. I will test it on Monday.

Thibaud

On Nov 13, 2015, at 3:48 PM, Gino Bustelo [email protected] wrote:

@thibaudh #95 just passed all test. We want to give it another look on Monday, but I would appreciate if you can give it a try and give us any feedback.


Reply to this email directly or view it on GitHub.

from declarativewidgets.

lbustelo avatar lbustelo commented on June 3, 2024

'make sdist' will create the tar. Then you use 'pip' to install. I never run setup.py directly.

Gino B.

On Nov 16, 2015, at 12:34 PM, Thibaud [email protected] wrote:

When running setup.py install, I got the following error:

tbh@Thibauds-MacBook-Pro:~/graphistry/declarativewidgets$ python setup.py install
Traceback (most recent call last):
File "setup.py", line 17, in <module>
with open(os.path.join(HERE, 'urth/widgets/ext/_version.py')) as f:
IOError: [Errno 2] No such file or directory: '/Users/tbh/graphistry/declarativewidgets/urth/widgets/ext/_version.py’

I am on commit cbdba0a. Did the install procedure change? I used to do make sdist followed by setup.py install

Thibaud

On Nov 13, 2015, at 4:40 PM, Thibaud Hottelier [email protected] wrote:

Great. I will test it on Monday.

Thibaud

On Nov 13, 2015, at 3:48 PM, Gino Bustelo [email protected] wrote:

@thibaudh #95 just passed all test. We want to give it another look on Monday, but I would appreciate if you can give it a try and give us any feedback.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.

from declarativewidgets.

lbustelo avatar lbustelo commented on June 3, 2024

Also remember that the packaging is done under dist/.

Gino B.

On Nov 16, 2015, at 12:34 PM, Thibaud [email protected] wrote:

When running setup.py install, I got the following error:

tbh@Thibauds-MacBook-Pro:~/graphistry/declarativewidgets$ python setup.py install
Traceback (most recent call last):
File "setup.py", line 17, in <module>
with open(os.path.join(HERE, 'urth/widgets/ext/_version.py')) as f:
IOError: [Errno 2] No such file or directory: '/Users/tbh/graphistry/declarativewidgets/urth/widgets/ext/_version.py’

I am on commit cbdba0a. Did the install procedure change? I used to do make sdist followed by setup.py install

Thibaud

On Nov 13, 2015, at 4:40 PM, Thibaud Hottelier [email protected] wrote:

Great. I will test it on Monday.

Thibaud

On Nov 13, 2015, at 3:48 PM, Gino Bustelo [email protected] wrote:

@thibaudh #95 just passed all test. We want to give it another look on Monday, but I would appreciate if you can give it a try and give us any feedback.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.

from declarativewidgets.

thibaudh avatar thibaudh commented on June 3, 2024

Oh right. setup.py now works without errors. But when running the demo notebook, I am still getting loading errors:

http://localhost:8888/notebooks/demos/urth_components/paper-input/paper-input.html Failed to load resource: the server responded with a status of 404 (Not Found)

:8888/static/services/sessions/session.js?v=20151116120427:52 Session: kernel_created (0996144d-ea01-47b3-a6b0-49ce18f8b444)

:8888/static/services/kernels/kernel.js?v=20151116120427:440 Starting WebSockets: ws://localhost:8888/api/kernels/00373f90-e001-4033-ac0e-e4c6bd85108d

:8888/nbextensions/urth_widgets/js/main.js?v=20151116120427:10 Custom JS loaded

:8888/static/base/js/utils.js?v=20151116120427:29 Loaded extension: urth_dash_js/notebook/main

:8888/static/base/js/utils.js?v=20151116120427:29 Loaded extension: urth_widgets/js/main

http://localhost:8888/urth_components/webcomponentsjs/webcomponents-lite.min.js Failed to load resource: the server responded with a status of 404 (Not Found)

:8888/nbextensions/urth_widgets/js/init/init.js?v=20151116120427:115 Failed to load web components polyfill: [object Event]

On Nov 16, 2015, at 11:13 AM, Gino Bustelo [email protected] wrote:

Also remember that the packaging is done under dist/.

Gino B.

On Nov 16, 2015, at 12:34 PM, Thibaud [email protected] wrote:

When running setup.py install, I got the following error:

tbh@Thibauds-MacBook-Pro:~/graphistry/declarativewidgets$ python setup.py install
Traceback (most recent call last):
File "setup.py", line 17, in <module>
with open(os.path.join(HERE, 'urth/widgets/ext/_version.py')) as f:
IOError: [Errno 2] No such file or directory: '/Users/tbh/graphistry/declarativewidgets/urth/widgets/ext/_version.py’

I am on commit cbdba0a. Did the install procedure change? I used to do make sdist followed by setup.py install

Thibaud

On Nov 13, 2015, at 4:40 PM, Thibaud Hottelier [email protected] wrote:

Great. I will test it on Monday.

Thibaud

On Nov 13, 2015, at 3:48 PM, Gino Bustelo [email protected] wrote:

@thibaudh #95 just passed all test. We want to give it another look on Monday, but I would appreciate if you can give it a try and give us any feedback.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.

from declarativewidgets.

lbustelo avatar lbustelo commented on June 3, 2024

Make sure you also installed the additional Pip requirements for Python 2.
https://github.com/jupyter-incubator/declarativewidgets/tree/Python2Support#install

Aside from that... not sure what else is different from our test environment. You can see the image where we are testing at https://github.com/jupyter-incubator/declarativewidgets/blob/Python2Support/etc/images/all-spark-notebook-bower/Dockerfile

from declarativewidgets.

thibaudh avatar thibaudh commented on June 3, 2024

That was the missing piece. Happy to report that Python 2.7 works for me :)

On Nov 16, 2015, at 12:49 PM, Gino Bustelo [email protected] wrote:

Make sure you also installed the additional Pip requirements for Python 2.
https://github.com/jupyter-incubator/declarativewidgets/tree/Python2Support#install https://github.com/jupyter-incubator/declarativewidgets/tree/Python2Support#install
Aside from that... not sure what else is different from our test environment. You can see the image where we are testing at https://github.com/jupyter-incubator/declarativewidgets/blob/Python2Support/etc/images/all-spark-notebook-bower/Dockerfile https://github.com/jupyter-incubator/declarativewidgets/blob/Python2Support/etc/images/all-spark-notebook-bower/Dockerfile

Reply to this email directly or view it on GitHub #50 (comment).

from declarativewidgets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.