Comments (3)
Would adding more unit tests help?
I have some specific data (i.e. barometric/qbit and gnss) and specific altitude calculation unit tests at: https://gitlab.com/wrobell/vmodes/-/blob/master/vmodes/tests/test_parser_altitude.py. Please feel free to take data from there. I also hope to bring more there soon.
from pymodes.
This is the changeset, which is causing above confusion
if tc < 19:
- # barometric altitude
- q = mb[15]
- if q:
- n = common.bin2int(mb[8:15] + mb[16:20])
- alt = n * 25 - 1000
- else:
- alt = None
+ altcode = altbin[0:6] + "0" + altbin[6:]
else:
- # GNSS altitude, meters -> feet
- alt = common.bin2int(mb[8:20]) * 3.28084
+ altcode = altbin[0:6] + "0" + altbin[6:]
+
IMHO, this is wrong change as ADS-B messages with typecode >= 20
are treated as barometric ones now.
from pymodes.
You are right @wrobell. Thanks for spotting this. It has been fixed in the lastest code now. I am not sure how did that happen π€¦ββοΈ π
from pymodes.
Related Issues (20)
- syntax error: expected ':'
- hdg values not being dumped HOT 1
- Modeslive throws ValueError: ctypes objects containing pointers cannot be pickled HOT 14
- TypeError
- Unused imports HOT 1
- [R82XX] PLL not locked HOT 3
- Incompatible gcc flags on non-AMD64 platforms HOT 4
- Unable to install with Pip on arm64 Ubuntu Server 20 (BananaPi-M5) HOT 6
- Build issues
- IndexError: list index out of range HOT 2
- Coding or comment error HOT 1
- Installation Error on Ubuntu 18.04.6 HOT 3
- Honor option '--help'
- Does Modes or ADSB trasnmits roll angle of the planeοΌ
- ValueError: max() arg is an empty sequence
- ModuleNotFoundError: No module named 'pyModeS.decoder.flarm.decode' HOT 3
- MRAR messages HOT 3
- ModuleNotFoundError: No module named 'pyModeS.decoder.flarm.decode'` HOT 6
- Date and Time
- Python 3.12 pypi package HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pymodes.