Comments (2)
I can't reproduce this problem locally. What vim version/platform and patchreview.vim plugin version etc. are you running? Does changing g:patchreview_split_right
to 0
instead give you the correct behavior for DiffReview
?
from patchreview-vim.
I changed it and I now get the correct behaviour. So I guess it's just a misunderstanding of the functionality on my part. Am I corret that this the intended behaviour:
- For patchreview, "current source" is the file without the patch applied, "diff" is the file with patches applied
- For diffreview, "current source" is the current state of the workspace, "diff" is the parent revision
I thought diffreview would use the parent as the current source and the changes on top of that as the diff, but I realize I was just wrong there. So this can be closed.
from patchreview-vim.
Related Issues (11)
- Support google/git-appraise reviews
- please add screenshots
- Cannot work on worktree HOT 3
- ERROR: 1 out of 1 hunk FAILED -- saving rejects to file /tmp/v8YAN3Y/349.rej¬ HOT 7
- 459b7ed breaks syntax highlighting HOT 2
- First tab does not show diff HOT 1
- Missing comment markers HOT 1
- old/new windows are backwards HOT 8
- Didn't detect new file correctly HOT 3
- error on running :DIffReview HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from patchreview-vim.