Comments (2)
I think that this issue generalizes to a broader scope. For example, I've encountered a similar problem when fixing a metatheory.jl test case regarding rewriting categorical expressions. I wanted to skip the walk of nodes with a certain specific operation
using Rewriters.Postwalk (this can be reduced/converted intuitively to the case of an istree(::T)
type), treating those nodes like terminals but only in a certain moment and scope. I still wanted to treat those nodes as trees during other tasks. Maybe a finer degree of control over istree
is needed. Wrapping all the MT calls to TermInterface.isexpr seems like a bad hardcoding choice, because if you want to rewrite Symbolics expressions that hold Expr
s as non-tree terminals MT would still treat them as trees without any degree of control. Lets chat about potential solutions that are not orthogonal to either packages design. I'm sure there is one that is compatible with both SU being specific on types and MT being as general as possible
cc @ChrisRackauckas and @philzook58 s for any suggestions
from terminterface.jl.
I would close this since the integration worked out well
from terminterface.jl.
Related Issues (18)
- Rethinking exprhead HOT 9
- `istree` should only receive objects and not types HOT 2
- Relationship to SymbolicUtils etc HOT 3
- TagBot trigger issue HOT 23
- Redesign proposal HOT 9
- (Possibly) move `wrap` and `unwrap` here HOT 1
- expr vs call? HOT 6
- base this on AbstractTrees.jl HOT 1
- all `maketerm` arguments should be mandatory HOT 2
- get rid of the fourth argument of `maketerm`, `type` HOT 16
- Improve docs before bumping new version
- request for new functions: `isvariable` and `variablename` HOT 4
- Should `issym` take type?
- outdated doc string copies in the README HOT 4
- Register HOT 1
- `unsorted_arguments` HOT 1
- Add `exprhead` function HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terminterface.jl.