Background not set? about plotlyjs.jl

[sglyon]

Yep, I know exactly what the problem is. When you try to set paper_bgcolor=x the PlotlyJS.jl underscore magic is applied and this gets applied and this is translated to Dict(:paper => Dict(:bgcolor => x)) instead of Dict(:paper_bgcolor => x)

I'll take a look at the backend code in Plots.jl and see if I can fix this.

[sglyon]

Looks like you managed to hit on one of just a few trace attributes that have underscores:

julia> using JSON

julia> d = JSON.parsefile(Pkg.dir("PlotlyJS", "deps", "plotschema.json"));

julia> get_keys(x) = [];

julia> get_keys(d::Associative) = vcat(collect(keys(d)), map(get_keys, values(d))...);

julia> get_keys(d["schema"]["layout"]) |> unique |> length
180

julia> get_keys(d["schema"]["traces"]) |> unique |> length
249

julia> unique(filter(x->contains(x, "_") && !(x[1] == '_'), get_keys(d["schema"]["traces"])))
5-element Array{Any,1}:
 "error_y"
 "error_x"
 "copy_ystyle"
 "copy_zstyle"
 "error_z"

julia> unique(filter(x->contains(x, "_") && !(x[1] == '_'), get_keys(d["schema"]["layout"])))
2-element Array{Any,1}:
 "plot_bgcolor"
 "paper_bgcolor"

I'm not really sure what the best way around this is. I noticed that you set the layout attributes using the relayout! methods, which is great. The problem with those is that they end up calling setindex!, which is where the underscore magic gets applied.

Any suggestions on an elegant way to deal with this? I think you should still use relayout!, but I should maybe add a kwarg to that function that describes if we should do the underscore replacing or just operate directly with the keys that were handed to us?

[sglyon]

Here's an idea...

What if arguments that are passed to relayout!s second argument in the dict are merged with the underlying layout dict without any processing. But, we continue to do _ processing for all attributes set via keyword arguments?

[tbreloff]

Good catch!

What if arguments that are passed to relayout!s second argument in the dict are merged with the underlying layout dict without any processing

This is the best option, if it doesn't break anything.

The other option is to keep a list valid_keys and only split if it's not in the list.

[sglyon]

OK fixed on my sl/ijulia-comm branch.

Will leave open here until we merge into master

[sglyon]

Done!