Coder Social home page Coder Social logo

Comments (3)

simonbyrne avatar simonbyrne commented on July 29, 2024

Thanks for the interest!

So, the problem is a little more complicated than floating point error: the line that's failing on Travis is actually this one, the purpose of which was to check that we're actually calling the correct method after overwriting the Base.sin method. Unfortunately, it seems like this isn't actually working correctly.

More generally, these tests should probably be rewritten to use BaseTextNext.jl, as FactCheck is slowly being deprecated.

from appleaccelerate.jl.

rprechelt avatar rprechelt commented on July 29, 2024

Ah; that makes sense! This is what happens when I just glance over this stuff late at night! My apologies for the "false" issue notice.

That being said, I'd be happy to tackle rewriting these tests using BaseTextNext.jl; I have been using AppleAccelerate.jl a lot for the last few weeks and would love to give back.

I have already implemented a number of other Accelerate functions (conv, xcorr, acorr and others) in my local repo; if these are functions you think we should merge in, I'll write some tests for them and make a PR.

from appleaccelerate.jl.

simonbyrne avatar simonbyrne commented on July 29, 2024

That would be great, thanks, contributions are certainly welcome. I think it would make sense to expose as much of Accelerate as possible.

from appleaccelerate.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.