Comments (4)
I will need to think about what the right answer is here. Before #52193 we indeed used the key
itself here.
But yes an objectid collision does cause a perfect hash collision. I am kinda curious how IdDict survives that.
from julia.
I will need to think about what the right answer is here. Before #52193 we indeed used the
key
itself here.
Even with pre-#52193 implementation rehashing was ineffective for some key types, e.g. Symbols. That's because hash(s::Symbol)
is defined as objectid(s)
and hash(s, h)
depends only on objectid(s)
:
https://github.com/JuliaLang/julia/blob/master/base/hashing.jl#L38-L40
from julia.
So looking at IDdict it also "just" uses objectid
and then uses the typical probe + egal check and grow the table on conflict.
For HAMT that statregy wouldn't work. We would probably need to introduce a "PerfectConflict" node with a linear probe,
but as you noted with Symbols this is a general property of using objectid
as source of the hash.
from julia.
I'm pretty sure it is a bug if objectid has collisions. It seems like something that could be provably made to cause miscompiles.
from julia.
Related Issues (20)
- Extension not loaded if trigger is a strong dependency [on 1.10] HOT 6
- `libutf8proc.a: error adding symbols: file format not recognized` blocking build on Windows 11 on ARM via WSL HOT 8
- 136x regression for LazyAritifacts HOT 4
- LinearAlgebra/addmul all-NAN batman? HOT 10
- `Markdown.parse(::LazyString)` errors
- Allow `stack` on empty collection HOT 1
- Learn program HOT 1
- `+` function string concatenation hint should not apply to zero args HOT 1
- Typed comprehension with begin/end is illegal syntax HOT 1
- Julia v1.11 (all RCs) breaks package SolidStateDetectors (not caught by PkgEval due to timeout)
- REPL precompilation workload is broken HOT 1
- `MethodError` thrown while preparing to throw `InexactError` in conversion of `Rational` to `Integer` or `Complex` to `Real` HOT 2
- `with_logger(NullLogger())` allocates in v1.11 HOT 2
- Artifact string resolution fails in Quarto/Jupyter context
- Segfault when reading CSV from within the R environment HOT 3
- crash when comparing a type to a kind
- Define `isless` for 0-dim arrays
- REPL precompile script not caching methods from runtime dispatch HOT 11
- Test failure in `LinearAlgebra/addmul` HOT 2
- Test failure in `LinearAlgebra/addmul` for 5-way `mul!` with `BigFloat` and `Bidiagonal` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from julia.