Coder Social home page Coder Social logo

Comments (12)

StefanKarpinski avatar StefanKarpinski commented on May 19, 2024 2

Too high. It would be much clearer if just doing @everywhere using Module worked. Rather than automatically doing code loading from the head node, how to load code should be configurable and you can say @workers command_that_tells_workers_to_load_code_from_node_1(). Otherwise they would just load code locally like a normal Julia process does by default.

from distributed.jl.

ViralBShah avatar ViralBShah commented on May 19, 2024 1

This seems a bit too magical.

from distributed.jl.

amitmurthy avatar amitmurthy commented on May 19, 2024

At least the worker should not terminate abruptly, it should give a clean error message.

The module PTools was not even required on the workers. The closure had some references - not obvious looking at the code - which caused the problem. It took me a while to figure it out.

The contra argument for auto-loading modules, of course, is that typically the visualization packages are only required on process id 1.

from distributed.jl.

ViralBShah avatar ViralBShah commented on May 19, 2024

It should certainly not crash.

from distributed.jl.

amitmurthy avatar amitmurthy commented on May 19, 2024

How about an additional keyword argument to addprocs called pkgsync

addprocs(n, pkgsync=true)    # The default. All packages currently loaded on 1 are loaded on the worker
addprocs(n, pkgsync=false)    # Nothing is loaded on the worker
addprocs(n, pkgsync=[pkgs...])    # Only specified packages are loaded

The packages loaded are the ones listed in Base.package_list I assume. We strip the path and filename extension and try to load these on the worker.

If you loaded scripts using include or packages not on the standard search path, they will not be sync'ed, you will need to do so explicitly on the new workers.

from distributed.jl.

amitmurthy avatar amitmurthy commented on May 19, 2024

Julia users link regarding the same issue - https://groups.google.com/d/msg/julia-users/-Y1rc8gkrgo/r6w5f144BkMJ

from distributed.jl.

timholy avatar timholy commented on May 19, 2024

Perhaps

using PTools
addprocs(1)
using PTools   # currently this has no effect on the worker

should cause PTools to be loaded on the worker?

(Discovered while testing JuliaLang/julia#8745 with the Images test, CC @vtjnash.)

from distributed.jl.

vtjnash avatar vtjnash commented on May 19, 2024

To fix the Images test, I added an @ everywhere before the import statement. With JuliaLang/julia#8745 changes to require, syncing modules during addprocs might be easier now.

from distributed.jl.

timholy avatar timholy commented on May 19, 2024

I got a module reload when I fixed it that way; I just pushed a different fix (to Images master, not tagged). But the fix uses a PR against JuliaLang/julia#8745 I'll be submitting shortly.

from distributed.jl.

andreasnoack avatar andreasnoack commented on May 19, 2024

@amitmurthy I think the level of magic in using/require here is either too low or too high.

  • Too low?
    If using automatically loads modules on workers then either modules loaded before addprocs should propagate or using, as in the example in https://github.com/JuliaLang/Distributed.jl/issues/17`, should load the module on the workers. Right now, you'll have to @everywhere using Module if the module is already loaded on master but the @everywhere solution ends up in a mess if the module hasn't already been loaded on master.
  • Too high?
    If we removed all the require magic where the code is also executed on workers then you could just always use @everywhere using Module. It would be quite simple to reason about.

from distributed.jl.

amitmurthy avatar amitmurthy commented on May 19, 2024

Related - #20

from distributed.jl.

Nosferican avatar Nosferican commented on May 19, 2024

Status of this?

from distributed.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.