Coder Social home page Coder Social logo

Comments (3)

m-lohmann avatar m-lohmann commented on June 4, 2024

I worked on DIN99 (originally Glenn Sweeney) and implemented DIN99o back then... I’ll have a look at the DIN99d conversion.
Probably the intermediate conversion step to XYZ is causing the problem.

Found the culprit: Several errors, rotation in wrong direction, one wrong sign in function cnvt{T}(::Type{XYZ{T}}, c::DIN99d)

This is what you get now:

julia> convert(RGB,convert(DIN99d,RGB(1,0.5,0.0)))
RGB{Float64}(0.9999999224685044,0.5000001510720956,0.0)

Should be fixed now.

from colors.jl.

hofmannmartin avatar hofmannmartin commented on June 4, 2024

Thank you very much. Could you make a pull request for your patch?

from colors.jl.

m-lohmann avatar m-lohmann commented on June 4, 2024

I thought I already had. Something must have gone wrong. I'll make a pull request as soon as I can.

Edit: Done

from colors.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.