Graceful parsing of Colorants about colors.jl

[timholy]

FYI colorant"red" by itself (without the parse) is all you need. But a pass-through would be great, if you want to submit that.

[tbreloff]

Yes... The issue came up somewhere in Plots, of course I'm still looking for the bug since the full stack trace isn't printed due to the stack overflow. (Is that a bug in julia?)

I'll put together a PR for the signatures I mentioned.

On Nov 16, 2015, at 11:48 AM, Tim Holy [email protected] wrote:

FYI colorant"red" by itself (without the parse) is all you need. But a pass-through would be great, if you want to submit that.

—
Reply to this email directly or view it on GitHub.

[timholy]

Ugh, StackOverflows shouldn't happen even in cases of user error, but I often forget to watch out for this.

The key technique is probably to change only one argument type at a time. Comparing

Colors.jl/src/parse.jl

Line 75 in 8309364

function Base.parse(::Type{Colorant}, desc::AbstractString)

and

Colors.jl/src/parse.jl

Line 136 in 8309364

Base.parse{C<:Colorant}(::Type{C}, desc) = convert(C, parse(Colorant, desc))::C

, I'd predict the StackOverflow should go away if you add ::AbstractString to the declaration of desc in the latter. If this is true, would be good to change this.

[timholy]

Fixed by #233