colormap breaking on 0.3 about colors.jl

[rohitvarkey]

Works fine on v0.5.1 though!

[stevengj]

Maybe base_color_type(C)(...) is relying on the implicit call to convert(base_color_type(C), ...) in 0.4+? Although the problem is probably in ColorTypes.jl, not Colors.jl, though.

[stevengj]

No, I don't think it is that. It is almost looking like a bug in 0.3 (I tried 0.3.11). I added some println statements to see what colormap is doing. The error occurs in the mix_linearly function in colormaps.jl, which I changed to:

    function mix_linearly{C<:Color}(a::C, b::C, s)
        println("color $C($a,$b,$s)")
        B = base_color_type(C)
        (arg1,arg2,arg3) = ((1-s)*comp1(a)+s*comp1(b), (1-s)*comp2(a)+s*comp2(b), (1-s)*comp3(a)+s*comp3(b))
        println("$B($arg1, $arg2, $arg3)")
        dump(B)
        r = B(arg1, arg2, arg3)
        println("got $r")
        return r
    end

which gives

julia> using Colors

julia> colormap("RdBu")
color LCHuv{Float64}(LCHuv{Float64}(12.0,40.2976566476583,12.10439529418943),LCHuv{Float64}(53.2590994583839,178.4759397727335,12.000000000000023),0.6)
{36.75545967503034,123.20462652270342,12.041758117675787}
LCHuv{T<:FloatingPoint}(36.75545967503034, 123.20462652270342, 12.041758117675787)
LCHuv
ERROR: type cannot be constructed
 in mix_linearly at /Users/stevenj/.julia/v0.3/Colors/src/colormaps.jl:138
 in sequential_palette at /Users/stevenj/.julia/v0.3/Colors/src/colormaps.jl:160
 in diverging_palette at /Users/stevenj/.julia/v0.3/Colors/src/colormaps.jl:233
 in colormap at /Users/stevenj/.julia/v0.3/Colors/src/colormaps.jl:290
 in colormap at /Users/stevenj/.julia/v0.3/Colors/src/colormaps.jl:264

However, if I type it manually at the REPL, it works fine:

julia> C = LCHuv{Float64}
LCHuv{Float64} (constructor with 1 method)

julia> B = base_color_type(C)
LCHuv{T<:FloatingPoint} (constructor with 4 methods)

julia> B(36.75545967503034, 123.20462652270342, 12.041758117675787)
LCHuv{Float64}(36.75545967503034,123.20462652270342,12.041758117675787)

[stevengj]

If I type the same mix_linearly function at the REPL, then mix_linearly(LCHuv{Float64}(12.0,40.2976566476583,12.10439529418943),LCHuv{Float64}(53.2590994583839,178.4759397727335,12.000000000000023),0.6) works fine.

Weird.

[IainNZ]

I'm seeing this on PkgEval now

[timholy]

Since we only support 0.4 and higher, this is no longer relevant.