Comments (2)
Hi, thanks for the tests @inkydragon
I also thought about the padding.
I think the same issue is also in the digest for the other SHA3 hash functions.
The padding of julia SHA is not along the NIST standards.
the Padding in the else case usedspace == blocklen(T)-1
should be
context.buffer[end] = 0x9f
for SHAKE_CTX
I tested the new padding and the output matches the python output then.
and one can also change the padding in the digest for SHA3_CTX
context.buffer[end] = 0x86
for sha3 digest function, but this (probably) is ivariant in the transform. So one would not need transform twice
from sha.jl.
Fixed by #95
from sha.jl.
Related Issues (20)
- Use julia-actions/cache to speed up CI
- New Release 0.7 or 0.8?
- Incorrect SHA-3 computation for message length just below multiple of block size HOT 1
- Faster SHA-3 implementations
- is this repo still maintained? HOT 2
- add fast sha2 to julia stdlib HOT 3
- Cap julia version on REQUIRE HOT 1
- Is there any interest in adding the SHA512/224 and SHA512/256 algorithms? HOT 1
- hmac_sha256 incorrect HOT 2
- [doc] missing docs
- Remove `Base.getproperty` HOT 2
- Run doctests on CI?
- Doctests are failing
- HMAC functionality needs to be added in SHA.jl documentation
- Docs: Say that contexts are unusable after calling `digest!`
- Specifying SHA.jl compatibility with Julia 1.6/1.7 HOT 3
- Package does not use hardware acceleration HOT 2
- sha256 is ~ 6x slower than python version HOT 1
- SHA objects HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sha.jl.