Coder Social home page Coder Social logo

shake128 test coverage about sha.jl HOT 2 CLOSED

juliacrypto avatar juliacrypto commented on July 17, 2024
shake128 test coverage

from sha.jl.

Comments (2)

immoschuett avatar immoschuett commented on July 17, 2024

Hi, thanks for the tests @inkydragon

I also thought about the padding.

I think the same issue is also in the digest for the other SHA3 hash functions.
The padding of julia SHA is not along the NIST standards.

the Padding in the else case usedspace == blocklen(T)-1 should be

context.buffer[end] = 0x9f for SHAKE_CTX

I tested the new padding and the output matches the python output then.

and one can also change the padding in the digest for SHA3_CTX

context.buffer[end] = 0x86 for sha3 digest function, but this (probably) is ivariant in the transform. So one would not need transform twice

from sha.jl.

inkydragon avatar inkydragon commented on July 17, 2024

Fixed by #95

from sha.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.