Expected Span or SpanContext, got NULL about jaeger-php

[santiagovillegasg]

Fixed using "jukylin/jaeger-php": "2.0.9-beta"

[cawolf]

I would consider this a bug in regards to the opentracing specification. The specification clearly states:

• extract() may return null
• startSpan() may throw a InvalidSpanOption (which has a named constructor for invalid references, such as null)

So I would suggest 2 things:

• @svillega : instead of downgrading, you should handle null results of extract() according to the specification and not pass it unchecked into startSpan(), as this should throw an exception
• @jukylin : we should alter this library to correctly throw the correct exception when null is passed

What do you think?

Best regards,
@cawolf

[jukylin]

I think is not friendly if engineer handle null results of extract().
So I want to check the result in startSpan() when null is passed.

if(array_search(null, $options) == "child_of"){
        $options = [];
};

you are right @cawolf , startSpan() can throw a InvalidSpanOption but not because the null

[cawolf]

Well actually, your library currently behaves like the opentracing specification is describing it, because you are utilizing StartSpanOptions::create(), from which the exception originally came from. I was wrong reopening this issue, but @svillega should still catch and handle the exception (which is declared in the opentracing interfaces) or explicitely check on null to avoid the error.

So no todo in your library, but this is a user error.

[jukylin]

@svillega Reference startActiveSpan

[santiagovillegasg]

@jukylin can you explain to me what's the difference between startSpan and startActiveSpan?
Thanks

[jukylin]

You can look here startSpan and startActiveSpan