Comments (5)
Mhh that used to work, we have a specifc error message for that which used to be shown if the team name didn't match the regex in the frontend. https://github.com/juice-shop/multi-juicer/blob/main/juice-balancer/ui/src/pages/JoinPage.js#L14
from multi-juicer.
This is how it looks for me (after pressing create=
![Screenshot 2023-09-23 at 12 04 17](https://private-user-images.githubusercontent.com/13718901/270100739-0b1cb24c-91d7-425d-80d5-2f33d41961d8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA5OTUzMjUsIm5iZiI6MTcxMDk5NTAyNSwicGF0aCI6Ii8xMzcxODkwMS8yNzAxMDA3MzktMGIxY2IyNGMtOTFkNy00MjVkLTgwZDUtMmYzM2Q0MTk2MWQ4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzIxVDA0MjM0NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJmZWNkMzY2MThmNzQ4ZjE0MzRmNDIyMjU2MzYxNmY3NTRhZGJhMmU2MzI2YzUwNTY5Y2JjYmUxYTNkYTJkNTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.6O7cbymQtBRjYgn89_cPw8vfHnHgdkRI6EXfNZoKt4g)
from multi-juicer.
I apologize for the confusion earlier. I had tested this on an older version 5.3.
I've now tested this on the latest version, ghcr.io/juice-shop/multi-juicer/juice-balancer:v7.0.0@sha256:3357a9aeb3f9d98017c14fc2d01589e12fe3d7a2c00ca9e37b18b5b2af45681e
and I am getting the same screenshot as you are.
Tested with the following browsers:
- Firefox 117.0.1 (same result as you)
- Edge 117.0.2045.31 (same result as you)
- Safari 16.6 (Safari is unique in its own way)
The safari version is not as elegant as those other browsers, however.
Given that Safari tends to behave differently, this issue can be considered resolved from my perspective.
from multi-juicer.
This was fixed with #174 😉
I wonder if it would make sense to align the error message for this and #179, though, to have a consistent UI. But I'll leave this up to @J12934.
from multi-juicer.
This was fixed with #174 😉
I wonder if it would make sense to align the error message for this and #179, though, to have a consistent UI. But I'll leave this up to @J12934.
Sorry I overlooked your comment earlier.
To me this is fine right now. I think having a different style for validation and for an actual error which was thrown for a valid input is totally fine.
I'm closing this ticket now. Thank you all for the input and feedback here 🙌
from multi-juicer.
Related Issues (20)
- OpenShift 4 instance issue HOT 4
- After click on "Start Hacking" only forwarded to the start page (with new team-name) HOT 3
- Issues when trying to customize shop with values.yml HOT 1
- Multi Juicer in an offline network HOT 2
- Missing points configuration for emptyUserRegistration HOT 3
- Move or replicate guides into Pwning OWASP Juice Shop HOT 2
- UI: Improve Feedback for Maximum Instances Limit Reached in Juice-Shop HOT 2
- Insufficient cpu on DO HOT 8
- Deprecated links in score board HOT 2
- Helm charts not being published since 5.3.0 HOT 2
- Relative time on admin page is wrong HOT 3
- Team passcode reset HOT 1
- Template variables could not be initialized: Datasource named Prometheus was not found HOT 2
- MultiJuicer doesn't run on microk8s without ClusterDNS enabled HOT 7
- connectionCache HOT 2
- Configuration Problems with Multi-Juicer HOT 4
- Public access deployed on Azure HOT 1
- Backup CodingChallenges Progess per Instance
- Add "reset team passcodes" button to admin page HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from multi-juicer.