Coder Social home page Coder Social logo

Comments (5)

J12934 avatar J12934 commented on July 24, 2024

Mhh that used to work, we have a specifc error message for that which used to be shown if the team name didn't match the regex in the frontend. https://github.com/juice-shop/multi-juicer/blob/main/juice-balancer/ui/src/pages/JoinPage.js#L14

from multi-juicer.

J12934 avatar J12934 commented on July 24, 2024

This is how it looks for me (after pressing create=

Screenshot 2023-09-23 at 12 04 17

from multi-juicer.

jonasbg avatar jonasbg commented on July 24, 2024

I apologize for the confusion earlier. I had tested this on an older version 5.3.

I've now tested this on the latest version, ghcr.io/juice-shop/multi-juicer/juice-balancer:v7.0.0@sha256:3357a9aeb3f9d98017c14fc2d01589e12fe3d7a2c00ca9e37b18b5b2af45681e and I am getting the same screenshot as you are.

Tested with the following browsers:

  • Firefox 117.0.1 (same result as you)
  • Edge 117.0.2045.31 (same result as you)
  • Safari 16.6 (Safari is unique in its own way)

The safari version is not as elegant as those other browsers, however.
image

Given that Safari tends to behave differently, this issue can be considered resolved from my perspective.

from multi-juicer.

stuebingerb avatar stuebingerb commented on July 24, 2024

This was fixed with #174 😉

I wonder if it would make sense to align the error message for this and #179, though, to have a consistent UI. But I'll leave this up to @J12934.

from multi-juicer.

J12934 avatar J12934 commented on July 24, 2024

This was fixed with #174 😉

I wonder if it would make sense to align the error message for this and #179, though, to have a consistent UI. But I'll leave this up to @J12934.

Sorry I overlooked your comment earlier.

To me this is fine right now. I think having a different style for validation and for an actual error which was thrown for a valid input is totally fine.

I'm closing this ticket now. Thank you all for the input and feedback here 🙌

from multi-juicer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.