Coder Social home page Coder Social logo

error when oauth url has pipe about fgraph HOT 4 CLOSED

jnylund avatar jnylund commented on August 18, 2024
error when oauth url has pipe

from fgraph.

Comments (4)

mttkay avatar mttkay commented on August 18, 2024

Same for us! Is that because FB changed the URLs they serve?

UPDATE: probably! we're only getting the error on some invocations, not all. Maybe they're AB-testing something or haven't yet rolled out the change to all their servers...

We believe we fixed it by patching the url_options method in fgraph.rb:

    def url_options(url)
        return unless url

        # Ruby's URI implementation craps out when the pipe symbol '|' is found
        uri = URI.parse(url.gsub('|', '%7C'))

        options = {}
        ...
    end

from fgraph.

mttkay avatar mttkay commented on August 18, 2024

@jnylund: doing parse(encode(url)) is a really bad idea, since this will break again as soon as Facebook fixes the issue and returns URLs that are already encoded (you will end up with a double-encoded URL)

from fgraph.

jnylund avatar jnylund commented on August 18, 2024

@kaeppler - agreed, have switched to your fix, thanks!

from fgraph.

jugend avatar jugend commented on August 18, 2024

Thanks for the note guys, patch is in 0.6.1

from fgraph.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.