Coder Social home page Coder Social logo

Comments (6)

GoogleCodeExporter avatar GoogleCodeExporter commented on July 22, 2024
Hiding the view immediately is important because the server typically displays 
some inappropriate instructions for the user once sign-in has completed.

I'm not sure which flow you are saying is ugly. Dismissal of the view 
controller without completing sign-in will not go through the popView method. 

Original comment by [email protected] on 7 Aug 2012 at 6:07

from gtm-oauth2.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 22, 2024
Dismissal after signed-in is ugly.

Original comment by [email protected] on 7 Aug 2012 at 3:42

from gtm-oauth2.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 22, 2024
When the user has signed in, the server will display an html message asking the 
user to copy an auth token. In the context of the sign-in controller, this 
messages does not make sense for the user, so the controller is trying to hide 
the message as quickly as possible.

Original comment by [email protected] on 7 Aug 2012 at 5:01

from gtm-oauth2.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 22, 2024
Then I think we can let the web view to show a more user friendly message such 
as "You've Signed In Successfully", instead of hiding the whole view.

Try presenting and dismissing GTMOAuth2ViewControllerTouch as a model view, 
you'll see it is really ugly to hide the view before the dismissing animation 
completes.

Original comment by [email protected] on 7 Aug 2012 at 5:13

from gtm-oauth2.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 22, 2024
We do not have control over what text the server displays in the html following 
sign-in.

Original comment by [email protected] on 7 Aug 2012 at 11:25

from gtm-oauth2.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 22, 2024
No but you have absolute control over what the webview shows up.

Original comment by [email protected] on 20 Apr 2013 at 3:53

from gtm-oauth2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.