Comments (6)
Hiding the view immediately is important because the server typically displays
some inappropriate instructions for the user once sign-in has completed.
I'm not sure which flow you are saying is ugly. Dismissal of the view
controller without completing sign-in will not go through the popView method.
Original comment by [email protected]
on 7 Aug 2012 at 6:07
from gtm-oauth2.
Dismissal after signed-in is ugly.
Original comment by [email protected]
on 7 Aug 2012 at 3:42
from gtm-oauth2.
When the user has signed in, the server will display an html message asking the
user to copy an auth token. In the context of the sign-in controller, this
messages does not make sense for the user, so the controller is trying to hide
the message as quickly as possible.
Original comment by [email protected]
on 7 Aug 2012 at 5:01
from gtm-oauth2.
Then I think we can let the web view to show a more user friendly message such
as "You've Signed In Successfully", instead of hiding the whole view.
Try presenting and dismissing GTMOAuth2ViewControllerTouch as a model view,
you'll see it is really ugly to hide the view before the dismissing animation
completes.
Original comment by [email protected]
on 7 Aug 2012 at 5:13
from gtm-oauth2.
We do not have control over what text the server displays in the html following
sign-in.
Original comment by [email protected]
on 7 Aug 2012 at 11:25
from gtm-oauth2.
No but you have absolute control over what the webview shows up.
Original comment by [email protected]
on 20 Apr 2013 at 3:53
from gtm-oauth2.
Related Issues (20)
- Patch for /trunk/Source/GTMOAuth2Authentication.h HOT 1
- GTMOAuth2Authentication expiresIn can return wrong type HOT 1
- ARC compatibility HOT 3
- GTMOAuth2ViewControllerTouch does not support endpoints using HTTP basic authentication
- assertion failure at GTMHTTPUploadFetcher.m:402 when using account with no YouTube channel HOT 6
- Unable to customize navigationBar/navigationItem properties if GTMOAuth2ViewController is the rootViewController
- Authentication breaks when redirectURI is of the form scheme:/path
- Invalid convertion from BOOL to (NSMutableDictionary*) HOT 1
- JSON format issue for POJO objects as @ApiMethod parameters
- Extension Grants
- GTMOAuth2ViewControllerTouch doesn't correctly handle dismissal with a pop gesture
- GTMOAuth2Authentication.refreshScope is either useless or broken HOT 1
- GTMOAuth2ViewControllerTouch needs refactoring HOT 1
- Application problem (Question by non-programmer, sorry) HOT 2
- iOS 7 user interface
- auth.userEmail getting wrong email address HOT 2
- iOS setCookie HOT 3
- Hi, i got an error while using vpn HOT 1
- Support text/javascript as valid content-type for JSON responses HOT 1
- Patch for /trunk/Source/GTMOAuth2Authentication.h HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gtm-oauth2.