Update channel loop bug about headscale

[kradalby]

Thats the stupidest I have been in a long time, I hit the wrong key and did not scroll far enough down 🤦‍♀️

[kradalby]

Fixed in Main

[jsiebens]

for the record, I've seen the same behaviour, causing high CPU usage during the loop

[kradalby]

I think I have noticed this as well, I will take a dive into it.

Based on the PR from that commit, it has ended up being a trade off of ensuring clients are up to date vs not getting all updates. For the time being I would say its better, but I will dive into it when I have some time.

I suspect its a timing and channel/lock issue.

[kradalby]

@busimus @jsiebens Hi, I am sure there is something, and that it is causing high cpu load, but I am struggling to see the loop in the example log provided.

The updates, and the "check if update is necessary" seem to be working as intended. I will agree that the update is somewhat aggressive, but I have not managed to spot the loop.

I might have read the wrong parts of the log, since it is quite comprehensive, would you manage to give me some pointers to how you understand it?

Meanwhile, I'll have a think if it can be made a bit less aggressive.

[busimus]

I truncated most of the loop and replaced it with ..., but I left a few iterations of the repeating five lines before and after that (e.g. lines from 220 to 224).

[kradalby]

I think this is resolved in #142, could any of you take it for a spin?

[busimus]

Yep, doesn't happen anymore with that PR.