Coder Social home page Coder Social logo

Comments (7)

jssor avatar jssor commented on August 17, 2024

@ayumihamsaki Great job, many thanks!

It's time to update event.keyCode with event.key, and the jquery version.
We will implement this in the coming version 28.0.0.

For "use strict", it's not necessary. It's not recommended to use “use strict” in ES6, ES6 modules are always in strict mode by default.

https://stackoverflow.com/questions/31685262/not-recommended-to-use-use-strict-in-es6

from slider.

 avatar commented on August 17, 2024

@jssor

I'm not talking about "use strict"; I am talking about === instead of ==.

Let me know if you need any changes to the attached pr, or you will merge it.

from slider.

jssor avatar jssor commented on August 17, 2024

Don't you think == work?

from slider.

 avatar commented on August 17, 2024

No you should not be doing that. It's 2019 there is no reason why you should not be using strict logical operators, that's just bad coding practises.

See here for the reason: https://stackoverflow.com/questions/359494/which-equals-operator-vs-should-be-used-in-javascript-comparisons

from slider.

jssor avatar jssor commented on August 17, 2024

I see.

Be aware that both === and "use strict" help for coding. It prevents unrestricted code, it reduces mistakes in your code. So, it's good behavior, please keep on. But if there is no mistake in your code, nothing matters.

=== is recommended good practice coding style.
== is also good practice coding style if you think so, it's up to you.

Again, thanks a lot!

from slider.

 avatar commented on August 17, 2024

@jssor Can I ask is this the main repo for JSSOR ? It seems very strange the setup here! You got a minify version only. How are people meant to work on the code if it's just a minify version here? You should have both, unminified and minified.

p.s. === and == do different things.

from slider.

jssor avatar jssor commented on August 17, 2024

not ready for some browsers yet, will change it in later version.

from slider.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.