Comments (7)
@ayumihamsaki Great job, many thanks!
It's time to update event.keyCode with event.key, and the jquery version.
We will implement this in the coming version 28.0.0.
For "use strict", it's not necessary. It's not recommended to use “use strict” in ES6, ES6 modules are always in strict mode by default.
https://stackoverflow.com/questions/31685262/not-recommended-to-use-use-strict-in-es6
from slider.
I'm not talking about "use strict";
I am talking about ===
instead of ==
.
Let me know if you need any changes to the attached pr, or you will merge it.
from slider.
Don't you think ==
work?
from slider.
No you should not be doing that. It's 2019 there is no reason why you should not be using strict logical operators, that's just bad coding practises.
See here for the reason: https://stackoverflow.com/questions/359494/which-equals-operator-vs-should-be-used-in-javascript-comparisons
from slider.
I see.
Be aware that both ===
and "use strict"
help for coding. It prevents unrestricted code, it reduces mistakes in your code. So, it's good behavior, please keep on. But if there is no mistake in your code, nothing matters.
===
is recommended good practice coding style.
==
is also good practice coding style if you think so, it's up to you.
Again, thanks a lot!
from slider.
@jssor Can I ask is this the main repo for JSSOR ? It seems very strange the setup here! You got a minify version only. How are people meant to work on the code if it's just a minify version here? You should have both, unminified and minified.
p.s. ===
and ==
do different things.
from slider.
not ready for some browsers yet, will change it in later version.
from slider.
Related Issues (20)
- Why does jssor issue a page request for every slide? HOT 6
- vuejs version HOT 8
- What is the correct way to add a youtube video as a slide? HOT 1
- Transition code of the website is not possible to use in the jquery code HOT 2
- $ScaleSize Does not work correctly HOT 1
- jssor instance wordpress HOT 2
- HTML code work properly but when ng-repeat use then all images show in page in angularjs. And when i click next button then all images work properly one by one HOT 1
- carousel-slider.slider with Bootstrap modal
- For mobile full screen slider how can i assign slide number for each slide For ex( 1 to 10 ) HOT 1
- $CurrentIndex() issue on first load HOT 2
- jssor fails tests because its still using non-passive Event Listeners HOT 2
- Optimize responsive HOT 1
- $JssorSlider$ error shows in React js for using jssor-slider
- Animations breakpoints no longer work since update from 27.5 to 28.0 HOT 2
- Font-size too big on mobile
- Lazy loading and SEO
- not compatible with iPad?
- Unable to insert caption below image
- Slid2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from slider.