Runtime errors in run_filing are print statements about 990-xml-reader

[jsfenfen]

Thanks so much for this detailed issue report.

You are absolutely right on all the code points.

This should probably be converted into a warning that only appears when verbose is chosen.

I may have occasion to address this in the next few months, this project has been pretty neglected.

I'm gonna add a longer list of years to suppress this.

FWIW the historical context is this: IRS used to regularly release the .xsd schema files; this library was built by parsing them. Of late these files have been harder and harder to come by, forcing folks to often run the library on schema versions where some xpaths (e.g. those added in the last tax year are unknown).

The process for updating the underlying metadata by hand or from .xsd files is pretty different, and it's not totally clear yet how IRS will land on this.

But suffice it to say the meaning of this warning has changed, and should be rethought.

[richarddunks]

Thanks for this. I'm happy to take care of #1. Exception handling isn't my forte as far as addressing #2 but there should be something for people to know there isn't anything in result, probably in the accessor function (`get_result`) so it fails properly, unless, like I said, returning an empty object is desirable behavior. #3 is more of a refactoring and I'm not sure how much of this you want done by someone outside the project, but I'm happy to help.

…

On Mon, Oct 25, 2021, 2:21 PM Jacob Fenton ***@***.***> wrote: Thanks so much for this detailed issue report. You are absolutely right on all the code points. This should probably be converted into a warning that only appears when verbose is chosen. I may have occasion to address this in the next few months, this project has been pretty neglected. I'm gonna add a longer list of years to suppress this. FWIW the historical context is this: IRS used to regularly release the .xsd schema files; this library was built by parsing them. Of late these files have been harder and harder to come by, forcing folks to often run the library on schema versions where some xpaths (e.g. those added in the last tax year are unknown). The process for updating the underlying metadata by hand or from .xsd files is pretty different, and it's not totally clear yet how IRS will land on this. But suffice it to say the meaning of this warning has changed, and should be rethought. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQPMYZOVXF4AKQJBR4X4ITUIWU4LANCNFSM5GV3U4TQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.