too much recursion about openjscad.org

[bmcage]

Further investigation shows this is due to end point and begin point of polygon being equal.

Simple test case to see this:

function main() {    
    var points = [new CSG.Vector2D(0,0)];
    points[1] = new CSG.Vector2D(0,10);
    points[2] = new CSG.Vector2D(10,10);
    points[3] = new CSG.Vector2D(0,0);
    var shape1 = CAG.fromPoints( points );
   return shape1;
}

At a minimum, a clear error to the user when begin and endpoint are equal would be nicest. Allowing begin=end would nicer still!

[bmcage]

test in openscad shows that begin=end is allowed there. Just paste:

polygon( points=[[0,0],[2,1],[1,2],[1,3],[3,4],[0,5],[0,0] ]);

and press F5 and F6.

[richievos]

@bmcage could you submit a pull request making that compatible with OpenSCAD's way of doing things? I haven't personally run into this, but seems like a quick fix.

[bmcage]

@richievos I don't have a patch, so not sure what you mean with a pull request. I would expect opening an issue to be the only step possible at the moment.

You hit the same bug when internal points are double. I have that in some procedurs for simplicity of code, eg a kerf on a lasercutter. If you set kerf=0, my procedures make polygons with twice the same point, which works in openscad, but not in openJSCAD, For openJSCAD, I need to add if then blocks testing on the 0.

[bebbi]

fixed in joostn/OpenJsCad#54
See also #33

[z3dev]

I tested the examples from @bmcage using Release 0.3.0. Both render properly. I'm closing this issue.