Coder Social home page Coder Social logo

Comments (6)

rtyler avatar rtyler commented on July 30, 2024

I suppose a question for you @ysb33r would be, is there any reason not to always run the tests as if they are "offline"?

from jruby-gradle-plugin.

ysb33r avatar ysb33r commented on July 30, 2024

Some tests need to connect to the internet to download gems as part of the test. When you are testing in an environment that does not have network connectivity run with ./gradlew --offline. Try that to see if it works for now.

(Having said that one test in JRubyPluginTest will still fail - I need to fix that)

from jruby-gradle-plugin.

rtyler avatar rtyler commented on July 30, 2024

@ysb33r the --offline flag definitely lets the tests run. Do you think tests passing with --offline is sufficient for a release

from jruby-gradle-plugin.

ysb33r avatar ysb33r commented on July 30, 2024

I would say no, but I would also wonder how you could build a released version without network connectivity?

from jruby-gradle-plugin.

rtyler avatar rtyler commented on July 30, 2024

@ysb33r I'm getting the above test failure very consistently from my laptop (the one I'm typing these comments from) so I don't think it's an online/offline thing. I'm in the chatroom now if you want to discuss further there

from jruby-gradle-plugin.

ysb33r avatar ysb33r commented on July 30, 2024

I'll give this a bit of think. A good starting point is https://github.com/robfletcher/gradle-compass/blob/master/gradle/integration-tests.gradle.

What I want to avoid is someone building a release without running the integration tests, but I also want to give people to options to skip the integration tests in normal development.

Maybe just allowing something like ./gradlew -PinterTest=0 to skip integration tests can do the trick.

[I'm leaving the option that ./gradlew --offline will avoid integration tests, but that is for the reason that --offline means we are using Gradle without a network connection and as such no network related activities should occur, including looking for repositories].

from jruby-gradle-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.