Comments (11)
Yes, I'd like to see such an exception for regex literals and URLs, although the former may eventually be rescinded by minification mapping new RegExp( "literal" + "literal" )
to an actual regex literal.
from contribute.jquery.org.
I'm ok with this.
from contribute.jquery.org.
I'll open a PR for this shortly. In the meantime, I'm going to move forward with this: jscs-dev/node-jscs#418
from contribute.jquery.org.
Sounds good. I can't wait to finally land JSCS in all projects.
from contribute.jquery.org.
mmm, why for the comments?
from contribute.jquery.org.
@markelog this is preventative for comments that contain long URLS. It seems based on this discussion that the comment exception was OK. If I misread this discussion, please correct me.
from contribute.jquery.org.
Yeah, the comment exception is ok. I was originally going to suggest using a URL shortener, but I think allowing long URLs in comments is better than relying on a third party URL shortener to be around forever.
from contribute.jquery.org.
So comments shouldn't be more than 100 chars with exception for URLs?
from contribute.jquery.org.
Correct.
from contribute.jquery.org.
Oh, I misunderstood. I put in a generic exception for comment length. I suppose I need to make the rule a bit smarter to only allow the exception if the comment contains a url.
from contribute.jquery.org.
@markelog I'll update that a bit later today.
from contribute.jquery.org.
Related Issues (20)
- Style Guide: Context-changing methods as first method call HOT 2
- CLA Checker: Show time of attempted verification HOT 3
- Wrong link to the github repository for the http://sizzlejs.com/ website HOT 9
- Update CLA check text in maintainers guide HOT 2
- Deploying command is kind of confusing HOT 10
- fresh jQuery style guide
- Clarify the need to setup Wordpress locally HOT 5
- Commits and Pull Requests: Inconsistent with current workflow HOT 6
- Document focus problems in IE HOT 2
- JS styleguide: Replacement for onevar HOT 1
- Document consistency goods with files examples HOT 5
- Prefix commit subjects with semver level HOT 23
- Please clarify documentation issues in "How to Report Bugs" -> Where to Report HOT 4
- Don't require spaces inside expression parentheses HOT 2
- Plugin contribute HOT 1
- Adopt standard module (for new projects) HOT 14
- The JavaScript Style Guide incorrectly says all projects use JSHint HOT 3
- drag actions not working on microsoft touch screen laptops HOT 1
- Delete "Verify the Author Info and CLA" section HOT 1
- CLA link redirects to OpenJS Foundation page with no CLA in evidence HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from contribute.jquery.org.