Coder Social home page Coder Social logo

Comments (11)

gibson042 avatar gibson042 commented on August 15, 2024

Yes, I'd like to see such an exception for regex literals and URLs, although the former may eventually be rescinded by minification mapping new RegExp( "literal" + "literal" ) to an actual regex literal.

from contribute.jquery.org.

scottgonzalez avatar scottgonzalez commented on August 15, 2024

I'm ok with this.

from contribute.jquery.org.

mikesherov avatar mikesherov commented on August 15, 2024

I'll open a PR for this shortly. In the meantime, I'm going to move forward with this: jscs-dev/node-jscs#418

from contribute.jquery.org.

scottgonzalez avatar scottgonzalez commented on August 15, 2024

Sounds good. I can't wait to finally land JSCS in all projects.

from contribute.jquery.org.

markelog avatar markelog commented on August 15, 2024

mmm, why for the comments?

from contribute.jquery.org.

mikesherov avatar mikesherov commented on August 15, 2024

@markelog this is preventative for comments that contain long URLS. It seems based on this discussion that the comment exception was OK. If I misread this discussion, please correct me.

from contribute.jquery.org.

scottgonzalez avatar scottgonzalez commented on August 15, 2024

Yeah, the comment exception is ok. I was originally going to suggest using a URL shortener, but I think allowing long URLs in comments is better than relying on a third party URL shortener to be around forever.

from contribute.jquery.org.

markelog avatar markelog commented on August 15, 2024

So comments shouldn't be more than 100 chars with exception for URLs?

from contribute.jquery.org.

scottgonzalez avatar scottgonzalez commented on August 15, 2024

Correct.

from contribute.jquery.org.

mikesherov avatar mikesherov commented on August 15, 2024

Oh, I misunderstood. I put in a generic exception for comment length. I suppose I need to make the rule a bit smarter to only allow the exception if the comment contains a url.

from contribute.jquery.org.

mikesherov avatar mikesherov commented on August 15, 2024

@markelog I'll update that a bit later today.

from contribute.jquery.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.