Upgrade to jQuery UI 1.9.0 about jquery-ui-rails

[jhilden]

Is there any way one could help with that?

[joliss]

Is there any way one could help with that?

Sure, that'd be lovely.

Mostly, the dependencies will need updating. The 1.8 dependencies in
the dependencies.js file were copied and pasted from the website. Can
we get a better source for the 1.9 dependencies? jquery-ui recently
changed to grunt as their build system, so I'm hopeful we don't have
to resort to copy and paste anymore.

[jhilden]

@joliss Could you outline a little more in detail what would need to happen it what order?

@jzaefferer would you maybe be available to help with that here in Cologne at some point?

[jzaefferer]

Sure, once I'm back, so early November.

Meanwhile, take a look at the manifest files that are in the release zip files (Downloads on GitHub or use grunt manifest to generate from source). They contain dependencies for each component. You should be able to generate dependencies.js based on that.

[joliss]

On Thu, Oct 18, 2012 at 5:37 PM, Jörn Zaefferer
[email protected] wrote:

You should be able to generate dependencies.js based on that.

I'm actually OK changing the format of dependencies.js - it was just
the JS hash that happened to be on the website.

It gets picked up in the Rakefile (try running rake assets). We can
adjust the Rakefile code however we want, so that we can take the
upstream dependency definitions as verbatim as possible.

[jzaefferer]

You can see the files here: https://github.com/jquery/jquery-ui/tree/1.9.0

As an example, here are the dependencies for autocomplete: https://github.com/jquery/jquery-ui/blob/1.9.0/ui.autocomplete.jquery.json#L56

[joliss]

On Thu, Oct 18, 2012 at 6:31 PM, Jörn Zaefferer
[email protected] wrote:

As an example, here are the dependencies for autocomplete:
https://github.com/jquery/jquery-ui/blob/1.9.0/ui.autocomplete.jquery.json#L56

Oh sweet. We may be able to read these files directly from the
Rakefile, perhaps?

[Aeon]

what specifically needs to be done to make this happen? I am willing to help

[luiscruz]

+1
I cannot use gem 'jquery-fileupload-rails', because my jquery-ui-widget is not updated.
One of the main advantages of using 'jquery-ui-rails' is to update libraries easier.
+1

[TylerRick]

Looking forwarding to using the Spinner widget from 1.9... (http://blog.jqueryui.com/2012/10/jquery-ui-1-9-0/)

[jhilden]

I took a stab at upgrading to jquery-ui 1.9.x and I think I got it figured out to resolve the Javascript dependencies using the newly provided .json files from jquery-ui, as mentioned by @jzaefferer

However, I'm not so sure on how the dependencies of the CSS files were figured out and what would need to change there.

You can find the code here: https://github.com/jhilden/jquery-ui-rails/tree/1-9-stable

Help is appreciated.

[jzaefferer]

Generally CSS files always come in pairs to the JS files, so you should just match those, then add core and theme files. Widget doesn't have CSS.

[jhilden]

Thanks for the pull request @stmontgomery

I looked over the code and your changes seem to be either equivalent or above mine. I also did a diff on the resulting assets and there were no differences.

So, I think we can close this issue in favor of #27 and I say +1 for merging the pull request.

[joliss]

Fixed by #27.